Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prepare monorepo #35

Closed
castarco opened this issue Sep 7, 2023 · 8 comments · Fixed by #43
Closed

build: prepare monorepo #35

castarco opened this issue Sep 7, 2023 · 8 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request monorepo Monorepo, automation, internal tooling refactor Code refactoring & reorganisation

Comments

@castarco
Copy link
Contributor

castarco commented Sep 7, 2023

Reorganise the code so the package @beautiful-tree/react is not at the root level of the repository, and we can have other packages as well.

Ideally, it should be done in a way that changes in a package only trigger the CI flow associated to that code and anything that depends on it, but nothing else (so we don't slow down our CI pipelines with useless work). Some tools that could help are Turbo Repo, or Nx.

This one is a precondition for the following tasks:

@castarco castarco added the refactor Code refactoring & reorganisation label Sep 7, 2023
@bhishekprajapati
Copy link

Hey! I'm interested in contributing to create the vue version of beautiful tree. How can I get started?

@castarco
Copy link
Contributor Author

castarco commented Sep 12, 2023

Hi @bhishekprajapati 😄 ,

If you feel brave enough to pick the monorepo task first (as it's kind of a precondition), you can start with it. If you don't feel comfortable with the monorepo task, I can prioritise it on my side, so you can start with Vue after we have it in place (As I was working on it alone, I wasn't prioritising it yet).

NOTE: you can pick any task and leave a message so we can know that you are on it.

My suggestion is to start with the ones marked as "good first issue", but of course feel free to pick something else if you have any other preference.

Once you have your changes, you can send them as a PR and I'll review them.

@bhishekprajapati
Copy link

Hi @castarco ,
I've zero experience of monorepos.
I'll pick the vue task!

@bhishekprajapati
Copy link

Hey @castarco, do you any discord server or slack?
It'll be easier to discuss approaches!

@castarco
Copy link
Contributor Author

Hi @bhishekprajapati , I'm sorry for the delay, I'm having a busy week. For the time being, there are no "real time" channels, but I'll prepare something this weekend 👍🏻 .

@bhishekprajapati
Copy link

@castarco
Sure!
Also, I saw the implementation. You did it using just svg.
I'm thing about implementing using html canvas.
What do you say?

@castarco
Copy link
Contributor Author

Hi @bhishekprajapati .

  1. I just created a "community" in Discord: https://discord.gg/dTapKEPEQe .
  2. we can move all the async generic conversations to the Discussions section of this project 😃 .
  3. I'm fine with an HTML Canvas implementation 😄 , I actually thought about that, but didn't want to put too much work on my shoulders. What I would do, though, is name it accordingly, so we have space for a "classic" SVG implementation as well. I'm thinking about something like @beautiful-tree/vue-canvas (feel free to explore other naming possibilities).

@castarco castarco self-assigned this Sep 15, 2023
@castarco
Copy link
Contributor Author

Going back to the main topic of this issue, I started working on it.

@castarco castarco added enhancement New feature or request monorepo Monorepo, automation, internal tooling labels Sep 15, 2023
castarco added a commit that referenced this issue Sep 16, 2023
Fixes #35 

In the long term, this monorepo structure won't be enough. We'll have to
add some extra automations, but for now it's good to go, as it allows us
to unblock many other tasks!! 🎉 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request monorepo Monorepo, automation, internal tooling refactor Code refactoring & reorganisation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants