-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing improvements #32
Comments
Yeah, but it's also the toughest one to test. We probably want test to not require an internet connection, if possible. And we have lots of side effects in that function too when AS decides to refine the package already. |
Yes, definitely... Although being able to manually set the refine flags in the jobs helps.
Well, I guess we can just fetch one of the Components files that appstream-generator produces, trim it to just have a couple of useful apps, and drop it in the repo. That would avoid using the
Maybe we have different approaches here or maybe I am misunderstanding it, but isn't this what we ideally want? The apk plugin can provide very little information about the apps (mostly installation status and version/updatable version). So in my mind, our refine should just take care of becoming the manager plugin for the apps created by AS and set installation status, version and the other little metadata we can provide. I managed to move forward one WIP branch taking care about this yesterday, so I just pushed to #35 if you want to assess if it fixes some of the side-effects you were thinking of. |
This allows to run more code on method calls and do more complicated stuff. Helps Cogitri#32
Using the template allows to run more code on method calls and do more complicated logic. Helps #32
Using the template allows to run more code on method calls and do more complicated logic. Helps #32
The refine is indeed now being tested through the other calls. No major regressions in a while. |
Since #31 there are some basics tests which should help with development. However, the test process and the code is certainly improvable. This issue aims to document the most obvious problems for future reference:
gs_plugin_refine
is not tested, and probably one of the most important ones for a well-looking application. For those tests, it might be a good idea to setexternal-appstream-urls
to have some real-world apps downloaded.appstream::source-file
during refine. See Refine fixes #35The text was updated successfully, but these errors were encountered: