Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Oil Dilution #16

Open
tomkor opened this issue Jul 20, 2017 · 1 comment
Open

Reset Oil Dilution #16

tomkor opened this issue Jul 20, 2017 · 1 comment

Comments

@tomkor
Copy link

tomkor commented Jul 20, 2017

Would you check this code?

bool SSMprotocol1::resetOilDilution(CMlevel_dt level, bool *success){

There's no Oil Dilution measurement / reset using the SSM1 protocol. SSM2protocol is the right place for this.
Looks like you are suggesting to do the reset as part of the Clear Memory Procedure ?
Both things should really be kept independent.
We could add it as an Adjustment, but maybe it's time to add a "Service Procedures" section...

    *success = false;
    if(_state != state_normal) return false;
    if(level != CMlevel_1) return false;
    char bytewritten = 0;
    const int adres=0x27D;
    char b;
    if(!_SSMP1com->readAddress(adres,&b)){
        resetCUdata();
        return false;
    }
    else{
        _SSMP1com->writeAddress(adres,b | 0x40,&bytewritten);

Delay needed ?

        _SSMP1com->readAddress(adres,&b);
        _SSMP1com->writeAddress(adres,b & ~0x40,&bytewritten);
        _SSMP1com->readAddress(adres,&b);
        if(b!=0) return false;

Is it really an error if the resulting value is != 0 ?
I'm pretty sure the other bits are used for different purposes...

    }

    return true;
}

Can you send me a dump of your ECUs flagbytes (in private if you want) ?

@tomkor
Copy link
Author

tomkor commented Jul 26, 2017

I use procedure from RomRaider Tools TestApp and it is work greate. I try to create another button into left panel with method to reset oil dilution in SSM2 protocol. But I cannot test this becouse my car is in workshop.

I try to implement some method to write loged data to file like csv or comma separated txt.

FreeSSM.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant