Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Lighting off on latest version of Three.js #88

Open
Jared-Sprague opened this issue Mar 4, 2021 · 1 comment
Open

[Bug] Lighting off on latest version of Three.js #88

Jared-Sprague opened this issue Mar 4, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Jared-Sprague
Copy link
Member

There was a High security vulnerability in Three.js that requires upgrading to the latest version of three.js which is 0.126.1.

I did that but now the Lighting is really screwed up on the terminal. See screenshot:
Screenshot from 2021-03-04 18-26-17

We need to figure out what changed in the THREE API that screwed up our lighting and then adjust our settings so it fixes it.

@mwcz

@Jared-Sprague Jared-Sprague added the bug Something isn't working label Mar 4, 2021
@mwcz
Copy link
Member

mwcz commented Mar 4, 2021

Cool, I've actually impressed that's the only thing that got messed up considering how big the jump was! Three.js does breaking changes every so often and I would have expected a lot more damage. Looks close enough that we can just tweak our colors to get it looking right again. This is also a great opportunity to try getting the game to look more like the cool bluish purple from the video rather than the hyper-saturated reddish purple we currently have.

@Jared-Sprague Jared-Sprague changed the title [Bug] [Bug] Lighting off on latest version of Three.js Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants