Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False extraction on property changes #1

Open
mspark opened this issue Mar 28, 2019 · 0 comments
Open

False extraction on property changes #1

mspark opened this issue Mar 28, 2019 · 0 comments

Comments

@mspark
Copy link

mspark commented Mar 28, 2019

If there are changed properties on a file, like new permissions, the commit will look like this.

r10000001
Index: test2.sh
===================================================================
--- test2.sh	(revision 4)
+++ test2.sh	(revision 5)
@@ -1,3 +1,2 @@
-hallo dies
 ist eine
-datei
+dateiaa

Property changes on: test2.sh
___________________________________________________________________
Deleted: svn:executable
## -1 +0,0 ##
-*
\ No newline at end of property

Problem

Anything below @@ is extracted as commit-content but it belongs to the artifact diff-header indeed.

Possible Solution

The result should be:

Index: test2.sh
===================================================================
--- test2.sh	(revision 4)
+++ test2.sh	(revision 5)
@@ -1,3 +1,2 @@
Property changes on: test2.sh
___________________________________________________________________
Deleted: svn:executable
## -1 +0,0 ##
-*
\ No newline at end of property

is the content of the diff-header for changed artifact "test2.sh"

and following

-hallo dies
 ist eine
-datei
+dateiaa

is extracted as commit-content for changed artifact "test2.sh"

The Question: How treat those lines

## -1 +0,0 ##
-*
\ No newline at end of property

Are those information important for anything inside the analyses process? @ckroeher

ToDo

Maybe there are other behaviors on different properties. Maybe -*or \ No newline at end of property is not always equal.
=> Check that

mspark added a commit to ssedevelopment/SvnCommitExtractor that referenced this issue Apr 4, 2019
Refactor extraction for changed artifacts.
Property information blocks will now extracted for each changed artifact
which is inside the given commit
mspark added a commit to ssedevelopment/SvnCommitExtractor that referenced this issue Apr 4, 2019
Property information blocks will now extracted for each changed artifact
which is inside the given commit.
See CommitAnalysisInfrastructure#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant