New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert ValuePreferences type to `Record<string, number>` #1323

Open

Falx opened this issue May 17, 2022 · 0 comments

Labels

⌛ has dependency 📝 task

Contributor

Falx commented May 17, 2022 •

edited by joachimvh

Loading

In commit afed963 the type of ValuePreferences was changed to {[key: string ]: number } to avoid a bug in Components-Generator.js.

Once the bug (Components-Generator.js#103) is fixed, the type of ValuePreferences should be reverted back to Record<string, number>.

The text was updated successfully, but these errors were encountered:

joachimvh added ⌛ has dependency 📝 task labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment