-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeLists vs Makefile #22
Comments
Hi and thanks for the report! We maintain the We should remove it accordingly, but it probably contains some hints in case someone actually wants to use the OpenCL version (instead of the CUDA tests that we focus on). |
I personally also added a Spack package that builds from CMake, as recommended. |
Don't build CMake projects in-source, please. Create a temporary build directory and execute |
@ax3l Makes sense. Could you add build instructions to the README? I assumed the cmake variant is the new one, but the readme clearly stated that the Makefile is the current version which was quite confusing. |
Yes, good idea. We initially thought our changes might be accepted upstream again and tried to change as little as possible. I think a decade later we can assume nothing will happen upstream anymore and so let's change more boldly along the repo lines ;) |
Why do you have both a
CMakeLists.txt
and aMakefile
? Which one is the preferred one?Considering that the
Makefile
is being overriden by cmake, can it be removed to avoid ambiguity?The text was updated successfully, but these errors were encountered: