Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-think our CI testing for PIConGPU #5043

Open
psychocoderHPC opened this issue Aug 19, 2024 · 1 comment
Open

re-think our CI testing for PIConGPU #5043

psychocoderHPC opened this issue Aug 19, 2024 · 1 comment
Labels
component: tests unit tests refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@psychocoderHPC
Copy link
Member

We need to re-think how we perform compile tests in PIConGPU.

PR #5042 is reducing the number of tests but this is fare away from bringing us into an accepted test time.
With #4723 we added PIConGPU unit tests. More code should be tested there and stuff tested there should be removed from our examples/test/benchmarks combination in cmakeFlags
@psychocoderHPC psychocoderHPC added refactoring code change to improve performance or to unify a concept but does not change public API component: tests unit tests labels Aug 19, 2024
@psychocoderHPC psychocoderHPC mentioned this issue Aug 19, 2024
Merged
@psychocoderHPC
Copy link
Member Author

A possible approche for particle solvers.
Instead of testing if we can compile different solver with cmakeFlags we could simply add more species with the different solvers activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tests unit tests refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psychocoderHPC