From 6b820608e8577eb345414d28d2e0a46ebbf2f462 Mon Sep 17 00:00:00 2001 From: futreall <86553580+futreall@users.noreply.github.com> Date: Sun, 10 Nov 2024 19:27:12 +0200 Subject: [PATCH 1/6] Update rules.md --- cmd/clef/rules.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/clef/rules.md b/cmd/clef/rules.md index 112dae6512..75641965cb 100644 --- a/cmd/clef/rules.md +++ b/cmd/clef/rules.md @@ -81,7 +81,7 @@ Additionally, a few more have been added Some security precautions can be made, such as: -* Never load `ruleset.js` unless the file is `readonly` (`r-??-??-?`). If the user wishes to modify the ruleset, he must make it writeable and then set back to readonly. +* Never load `ruleset.js` unless the file is `readonly` (`r-??-??-?`). If the user wishes to modify the ruleset, he must make it writable and then set back to readonly. * This is to prevent attacks where files are dropped on the users disk. * Since we're going to have to have some form of secure storage (not defined in this section), we could also store the `sha3` of the `ruleset.js` file in there. * If the user wishes to modify the ruleset, he'd then have to perform e.g. `signer --attest /path/to/ruleset --credential ` From f23e013e9c213566a41d809bcb98b15130e12e6a Mon Sep 17 00:00:00 2001 From: futreall <86553580+futreall@users.noreply.github.com> Date: Sun, 10 Nov 2024 19:29:38 +0200 Subject: [PATCH 2/6] Update README.md --- cmd/evm/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/evm/README.md b/cmd/evm/README.md index cdff41f904..41d2e98ce7 100644 --- a/cmd/evm/README.md +++ b/cmd/evm/README.md @@ -6,7 +6,7 @@ which can 1. Take a prestate, including - Accounts, - Block context information, - - Previous blockshashes (*optional) + - Previous blockhashes (*optional) 2. Apply a set of transactions, 3. Apply a mining-reward (*optional), 4. And generate a post-state, including @@ -16,7 +16,7 @@ which can ## Specification -The idea is to specify the behaviour of this binary very _strict_, so that other +The idea is to specify the behavior of this binary very _strict_, so that other node implementors can build replicas based on their own state-machines, and the state generators can swap between a `geth`-based implementation and a `parityvm`-based implementation. From 12c19b47cbb0a89e961b09c651a2a5efd2d6589b Mon Sep 17 00:00:00 2001 From: futreall <86553580+futreall@users.noreply.github.com> Date: Sun, 10 Nov 2024 19:34:17 +0200 Subject: [PATCH 3/6] Update README.md --- cmd/faucet/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/faucet/README.md b/cmd/faucet/README.md index 364689a782..94ea2de34b 100644 --- a/cmd/faucet/README.md +++ b/cmd/faucet/README.md @@ -10,7 +10,7 @@ The `faucet` is a single binary app (everything included) with all configuration First thing's first, the `faucet` needs to connect to an Ethereum network, for which it needs the necessary genesis and network infos. Each of the following flags must be set: -- `--genesis` is a path to a file containin the network `genesis.json` +- `--genesis` is a path to a file containing the network `genesis.json` - `--network` is the devp2p network id used during connection - `--bootnodes` is a list of `enode://` ids to join the network through @@ -47,4 +47,4 @@ Sybil protection via Facebook uses the website to directly download post data th ## Miscellaneous -Beside the above - mostly essential - CLI flags, there are a number that can be used to fine tune the `faucet`'s operation. Please see `faucet --help` for a full list. \ No newline at end of file +Beside the above - mostly essential - CLI flags, there are a number that can be used to fine tune the `faucet`'s operation. Please see `faucet --help` for a full list. From 63542f0ea7bc94b794805386aff0a34152e16238 Mon Sep 17 00:00:00 2001 From: futreall <86553580+futreall@users.noreply.github.com> Date: Sun, 10 Nov 2024 19:35:36 +0200 Subject: [PATCH 4/6] Update CONTRIBUTING.md --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index b66b68f4a6..de164ab420 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -36,7 +36,7 @@ Please see the [Developers' Guide](https://geth.ethereum.org/docs/developers/dev for more details on configuring your environment, managing project dependencies and testing procedures. -## Issue reproductibility +## Issue reproducibility Before you create an issue, please try to reproduce it with [quorum quick dev start framework](https://github.com/ConsenSys/quorum-dev-quickstart) with the latest release. Many issues have been creating under an environment we are not able to reproduce quickly. From c10b00ccc264e73b3ab9d5a0c539689d28eac804 Mon Sep 17 00:00:00 2001 From: futreall <86553580+futreall@users.noreply.github.com> Date: Sun, 10 Nov 2024 19:37:50 +0200 Subject: [PATCH 5/6] Update README.md --- tests/fuzzers/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fuzzers/README.md b/tests/fuzzers/README.md index 7611c53698..6cb6c16f53 100644 --- a/tests/fuzzers/README.md +++ b/tests/fuzzers/README.md @@ -32,7 +32,7 @@ go-fuzz -bin ./rlp/rlp-fuzz.zip ### Notes Once a 'crasher' is found, the fuzzer tries to avoid reporting the same vector twice, so stores the fault in the `suppressions` folder. Thus, if you -e.g. make changes to fix a bug, you should _remove_ all data from the `suppressions`-folder, to verify that the issue is indeed resolved. +e.g. make changes to fix a bug, you should _remove_ all data from the `suppressions`folder, to verify that the issue is indeed resolved. Also, if you have only one and the same exit-point for multiple different types of test, the suppression can make the fuzzer hide different types of errors. So make sure that each type of failure is unique (for an example, see the rlp fuzzer, where a counter `i` is used to differentiate between failures: From e378969206921c01fe577dca9d7e24b569bedfa6 Mon Sep 17 00:00:00 2001 From: futreall <86553580+futreall@users.noreply.github.com> Date: Sun, 10 Nov 2024 19:38:34 +0200 Subject: [PATCH 6/6] Update README.md --- accounts/scwallet/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accounts/scwallet/README.md b/accounts/scwallet/README.md index 4313d9c6b2..28079c4743 100644 --- a/accounts/scwallet/README.md +++ b/accounts/scwallet/README.md @@ -8,7 +8,7 @@ ## Preparing the smartcard - **WARNING: FOILLOWING THESE INSTRUCTIONS WILL DESTROY THE MASTER KEY ON YOUR CARD. ONLY PROCEED IF NO FUNDS ARE ASSOCIATED WITH THESE ACCOUNTS** + **WARNING: FOLLOWING THESE INSTRUCTIONS WILL DESTROY THE MASTER KEY ON YOUR CARD. ONLY PROCEED IF NO FUNDS ARE ASSOCIATED WITH THESE ACCOUNTS** You can use status' [keycard-cli](https://github.com/status-im/keycard-cli) and you should get _at least_ version 2.1.1 of their [smartcard application](https://github.com/status-im/status-keycard/releases/download/2.2.1/keycard_v2.2.1.cap)