Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to keep note forever #321

Closed
3 tasks done
ilyakonovalenko opened this issue Nov 8, 2024 · 5 comments · Fixed by #341
Closed
3 tasks done

Option to keep note forever #321

ilyakonovalenko opened this issue Nov 8, 2024 · 5 comments · Fixed by #341
Assignees
Labels
enhancement New feature or request

Comments

@ilyakonovalenko
Copy link
Contributor

What type of request is this?

New feature idea

Clear and concise description of the feature you are proposing

Currently there is no way to keep note forever. 1 month may not be enough in some cases.

Additional context

No response

Validations

  • Check the feature is not already implemented in the project.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Check that the feature is technically feasible and aligns with the project's goals.
@ilyakonovalenko ilyakonovalenko added the enhancement New feature or request label Nov 8, 2024
@CorentinTh
Copy link
Owner

CorentinTh commented Nov 11, 2024

Hi @ilyakonovalenko
Thank you for your feedback. Adding a "never expire" option is indeed a good idea.
Before implementing it, I have some concerns:

  1. Adding another entry in the expiration delay picker may cause some overflow.

    • Option 1: Add a "never" option in the selector on the right. image
    • Option 2: Add a "never expire" checkbox like below the picker.
    • Option 3: Use a more traditional select with dropdown, not really fan, it adds more clicks.
  2. I may disable this feature for the public instance for multiple reasons:

    • The instance is free and since it's fully open-source, I don't want to pay for a lot of storage.
    • Their is a risk of abuse, someone could use the instance to store illegal content since it does not require any authentication.

Enclosed was designed to share ephemeral content, so I didn't think about adding such persistent feature. But I understand that it could be useful in some cases.

@Zoobdude
Copy link
Contributor

+1 for the 'never' selector using a separate toggle.

Making it possible to disable this via a ENV var would be ideal.

@CorentinTh CorentinTh self-assigned this Nov 11, 2024
@ilyakonovalenko
Copy link
Contributor Author

Option 1 would be good, but some CSS adjustments needed (maybe lower font size or reduced padding).

@joshwithers
Copy link

I'd love to have a config page to disable this :)

@CorentinTh
Copy link
Owner

CorentinTh commented Nov 16, 2024

I added a toggle to allow the creation of notes that never expiresin #341, it's available for version >= 1.11.0

  • Set PUBLIC_IS_SETTING_NO_EXPIRATION_ALLOWED to allow users to create notes that never expires, it is disabled by default
  • It's disabled on the public instance
  • Additionally you can use PUBLIC_DEFAULT_NOTE_NO_EXPIRATION to configure weither the note should never expires by default

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants