Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese language support #270

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

kogakisaki
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed 🔨 Building (View Log) 958bd8a
enclosed-docs ✅ Ready (View Log) Visit Preview 958bd8a

Copy link

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed-docs 🔨 Building (View Log) 1805d6e

Zoobdude

This comment was marked as duplicate.

Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kogakisaki
Thank you for the PR 🙏

Can you register the new langage entry in packages/app-client/src/modules/i18n/i18n.constants.ts please (cf CONTRIBUTING.md)

Copy link

Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 🙏

@CorentinTh CorentinTh merged commit 53a9d74 into CorentinTh:main Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants