mock_env() contains invalid Address

[Buckram123]

MockApi after 2.0 expects valid bech32 address, so current implementation of mock_env() would fail address validation:

            address: Addr::unchecked("cosmos2contract"),

I would prefer to have valid address instead, for example

            address: MockApi::default().addr_make("cosmos2contract"),

Or more flexible with passing MockApi inside mock env function:

            address: mock_api.addr_make("cosmos2contract"),

[Buckram123]

And is there a simpler way to get address prefix than from env.contract.address?

[chipshort]

            address: MockApi::default().addr_make("cosmos2contract"),

This will be fixed for mock_env in 2.2. See here: https://github.com/CosmWasm/cosmwasm/blob/v2.2.0-rc.1/CHANGELOG.md#L43-L45

The other part will be fixed in 3.0 by requiring an api parameter for mock_env: #2218

[chipshort]

And is there a simpler way to get address prefix than from env.contract.address?

The simplest way is to know what chain you deploy on and just use their prefix. Why do you need it at runtime?
Ideally, you would just write code that is agnostic of the underlying address scheme.

[Buckram123]

Why do you need it at runtime?

To generate address from public key. Don't want to have different wasm for each chain I deploy

[chipshort]

Ah, I see. To avoid a different wasm per chain, you could also make it a parameter in the InstantiateMsg.

If you really really want it programmatically, you'd have to go through a Stargate / Grpc query. It has to be allowlisted by the chain, but most chains have pretty big allow lists. See neutron for example: https://docs.rs/neutron-std/latest/neutron_std/types/cosmos/auth/v1beta1/struct.AuthQuerier.html#method.bech32_prefix
But I don't think it's worth the hassle.