Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check on SVD decomposition #17

Open
giordano opened this issue Aug 21, 2019 · 0 comments
Open

Missing check on SVD decomposition #17

giordano opened this issue Aug 21, 2019 · 0 comments

Comments

@giordano
Copy link
Collaborator

If SVD decomposition fails at

svd ( U, s, V, Asmall );
then s is reset and the following instruction s( 0 ) causes the program to terminate with the following error:

error: Mat::operator(): index out of bounds
terminate called after throwing an instance of 'std::logic_error'
  what():  Mat::operator(): index out of bounds

svd function actually returns a bool flag to indicate whether decomposition was successful or not. Glimpse should check the value of the returned flag and deal with the case where the decomposition failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant