Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SimPSFToolkit.py #99

Open
jeipollack opened this issue Dec 12, 2023 · 0 comments
Open

Refactor SimPSFToolkit.py #99

jeipollack opened this issue Dec 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jeipollack
Copy link
Contributor

The organisation of the SimPSFToolkit.py is very complex with various components comprising the class PSFToolkit that could be decoupled e.g. SED-related functions, telescope properties, etc. into their own class objects. Naming of functions and classes could be improved, e.g. its unclear whether poly means polynomial or polychromatic.

It also doesn't seem necessary to have plotting commands at L1009 inside the function generate_poly_PSF.
@jeipollack jeipollack added the enhancement New feature or request label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeipollack