Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle SSL errors in badly set up servers #104

Open
richard-jones opened this issue Aug 27, 2014 · 3 comments
Open

handle SSL errors in badly set up servers #104

richard-jones opened this issue Aug 27, 2014 · 3 comments
Milestone

Comments

@richard-jones
Copy link
Member

doi: 10.5007/2175-8077.2011v13n30p249

resolves to: https://www.periodicos.ufsc.br/index.php/adm/article/view/20275

But on connection in a browser we are warned about the SSL certificate. This needs to be handled in one of two ways:

1/ Catch the SSLError and record a proper error against the record in OAG
2/ Ignore (is that wise?) warnings about SSL certificates

@richard-jones richard-jones added this to the Jisc Monitor milestone Aug 27, 2014
@emanuil-tolev
Copy link
Contributor

Yeah, it's fine to ignore. Basically: do you care about the integrity of the data? Publishers' servers can serve us bollocks if they want to anyway. This is far more likely to be a misconfigured server than a man-in-the-middle attack to ... what, falsify license info :)? Will ignore.

@emanuil-tolev
Copy link
Contributor

(Obviously passwords and other sensitive things being transmitted is a case where you would care.)

@richard-jones
Copy link
Member Author

In which case I may already have fixed this - there was a problem with the error reporting when there were SSLErrors, so I put in a fix to serialise the errors properly. That should mean that errors get properly recorded in the cache, but hasn't been tested in the wild yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants