Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid DOI causes a 500 error. #96

Open
marcrohloff opened this issue Jun 30, 2014 · 2 comments
Open

Invalid DOI causes a 500 error. #96

marcrohloff opened this issue Jun 30, 2014 · 2 comments
Labels
Milestone

Comments

@marcrohloff
Copy link

The DOI 10.1016/0958–1669(95)80016–6 causes a 500 internal server error (I am using the API but I see this on the lookup page too). Note that those are unicode dashes \u2013. If I use 'normal' \u002d dashes then it works without error.

Not saying that I expect a result since this DOI is obviously incorrect. I just don't think that it should return a 500 error.

@emanuil-tolev
Copy link
Contributor

Yeah, it shouldn't - thanks for reporting. We don't screen the identifiers much, possibly just strip spaces and such. This should report 400 Bad Request if any non-ASCII characters are detected in the identifiers.

Also just a note for later: I'd be wary of starting to strip or replace stuff on the fly, it breaks the feedback loop of "what I put in" vs. "what happened" - so we should report the problem and let the user fix it if they want to.

@marcrohloff
Copy link
Author

Since we do batch processing my preference would be to see it in the errors result array

@richard-jones richard-jones added this to the Jisc Monitor milestone Aug 15, 2014
@richard-jones richard-jones self-assigned this Aug 15, 2014
@richard-jones richard-jones removed their assignment Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants