Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasets ~=1.18 requirement introduces conflict w/ numpy > 1.23 #24

Open
gregoryfoster opened this issue Nov 16, 2023 · 3 comments
Open
Labels
bug Something isn't working

Comments

@gregoryfoster
Copy link

gregoryfoster commented Nov 16, 2023

Describe the Bug

speakerbox requires datasets~=1.18 which in turn requires numpy>=1.17. The datasets 1.x line hasn't been updated since mid-2022. numpy v1.20 deprecated use of aliases of built-in types and expired those deprecations in v1.24. The datasets 1.x line uses those aliases, so a default install of speakerbox fails during training.

Expected Behavior

Training should work.

Reproduction

pipenv install speakerbox==1.2.0
Use speakerbox.train()

Environment

  • OS Version: macOS 13.4
  • Python: 3.10.13
  • speakerbox Version: 1.2.0
@gregoryfoster gregoryfoster added the bug Something isn't working label Nov 16, 2023
@gregoryfoster
Copy link
Author

To workaround, install numpy <= v1.23.

@evamaxfield
Copy link
Member

Is the fix for this just updating the numpy pin / the datasets pin in the library?

@kristopher-smith
Copy link

This could probably benefit from a requirements.txt file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants