incorrect ponder for redstone links

[drwoops]

Describe the Bug

linkRange is 256 by default, but the ponder says:

.text("Receivers emit the redstone power of transmitters within 128 blocks")

Reproduction Steps

run the redstone link ponder

Expected Result

the ponder should say 256 or better yet should use the current value of linkRange

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

N/A

Mod Version

0.5.1d

Minecraft Version

1.20.1

Forge Version

N/A

Other Mods

No response

Additional Context

No response

[Attack8]

Ok, thanks!

[alessiodam]

I'll fix that when I get time

[Attack8]

I'll fix that when I get time

I looked into it today and it’s actually kinda challenging to get it to respect the current value of linkRange. It looks like it will take a bit more backend work to get it working.

[alessiodam]

I love challenges so I'll take it :)

[Attack8]

Ok, cool! I’ll let you take a shot at it then!

[alessiodam]

Thanks ! Actually it could be pretty easy it'd basically just importing the class and requesting the value from there but it will add some lines of code and some boilerplate xD

[Attack8]

Ok! I couldn’t figure it out so I’ll be exited to see what you come up with

[alessiodam]

Nice I'll do a PR when I get the time to do it ;) already forked it gotta wait for the code indexing to be done.

[alessiodam]

Create/src/main/java/com/simibubi/create/infrastructure/config/CLogistics.java

Line 10 in 2201d87

public final ConfigInt linkRange = i(256, 1, "linkRange", Comments.linkRange);

[alessiodam]

At this point it's just requesting from config xD

[Attack8]

It’s not that that’s the issue, I have coded configs for Create before. It’s the adding it into the ponder system, which I am less familiar with, that proved to be problematic.

[drwoops]

i would abstract it into a constant(String) builder instruction and have a way to register resolvers that would return a string value.

[Attack8]

Ok, but then it wouldn’t change when you change configs because of the translation support built into the ponder system.

[drwoops]

are the ponders constructed in advance or on the fly when run?

[alessiodam]

They are constructed in advance, not on the fly.
I'm reinstalling IntelliJ IDEA and I'll clone my fork and start trying fixing all those issues that are open including this one, wanted to give ya an update

[alessiodam]

Question for a contributor: Which IDE do you use for Java, just wanna know?

[alessiodam]

Any ideas on how to generate the ponders 💀 I got the correct code but it still shows up as 128 blocks..
I did gradle build, and then gradle runClient

[kaileh57]

I think there should be a task to rebuild the ponders but I'm not 100% sure. Try looking for buildponder or something.

[alessiodam]

Doesn't seem to exist something like that

[alessiodam]

@simibubi sorry for tagging you but I'm trying to help you fix open issues and I would like to know how to build the ponders because I don't find it in gradle

[alessiodam]

Why closed?

[IThundxr]

It's been fixed in dev and subsequently closed

[alessiodam]

alright