-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] --prod
flag includes devDependencies
of workspace packages in module's dependencies
list
#256
Comments
Thank you for the report. And thank you for providing an environment where the situation may be reproduced. |
This comment has been minimized.
This comment has been minimized.
Hi @jkowalleck I fixed the settings in the reproduction git repo, you should (after fresh git pull) be able to run it locally yourself. May I ask you to delete your last comment, because of the internal company URL? :) Thanks for having a look! |
it is still there: https://github.com/Llois41/cyclondx-dev-dependency-reproduction/blob/300481488a32697a2b27e3f648ee792fd6686432/.yarnrc.yml#L1 Also, i do not see a reason for obscurity. so i think there is no need to worry about anything. |
some brief research showed, that the workspace support was lacking features. |
yeah, I didn't clean up the history, but the new master should at least work :D And yeah, I also think, it is no issue. @jkowalleck Alright, thanks for creating the collector issue. Can you give a rough estimation when you will have the capacity to work on the workspace support? If others run into this issue as well: For now we workaround by installing only production dependencies and then use the "zero-install yarn dlx wrapper", but this makes versioning a little bit harder, since we have to add a separate renovate config rule instead of just having the dependency in our package.json ^^ |
I might have some time in the next 6 months. can not promise anything. Anyway, this tool is a community effort. Everybody is invited to contribute :-D |
Describe the bug
When having a workspace package, importing it as a dependency leads
cyclonedx-yarn
to include their devDependency in the SBOM as well.To Reproduce
https://github.com/Llois41/cyclondx-dev-dependency-reproduction/tree/master
Expected behavior
I would expect that in the created sbom.json file there will also only be production dependencies of the workspace's package.
Environment
Contribution
The text was updated successfully, but these errors were encountered: