Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Allow enchants/addon items to increase blood from kills #780

Open
Lykrast opened this issue Jul 21, 2019 · 1 comment
Open

Comments

@Lykrast
Copy link

Lykrast commented Jul 21, 2019

Issue type:

  • ➕ Feature request

Short description:

The code that determines how much blood you get from a kill is very hardcoded. It would be nice to have a way to make our own version of the Vein Sword or something for a potential addon.

My precise idea was to put an Enchantment that increases how much blood you get per kill with multiple levels. This may not be fit for the main mod (up to you) but for an addon it'd be a neat thing and it doesn't look like it's currently doable (unless done indirectly like a separate event filling blood or dropping condensed blood).

@rubensworks
Copy link
Member

Sure, something like a BloodObtainEvent could be created, which would be supplied with an initial blood amount, and modifiable by other mods on the bus.

I'd be happy to accept a PR that implements something like this!

(Note to self: clean up that horrible indentation...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Options
Development

No branches or pull requests

2 participants