Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token/password protected http proxy #3

Open
thetakodev opened this issue Jul 13, 2018 · 5 comments
Open

Token/password protected http proxy #3

thetakodev opened this issue Jul 13, 2018 · 5 comments
Labels

Comments

@thetakodev
Copy link
Contributor

Issue type:

  • ➕ Feature request

Short description:

Please add an option to protect with password, token or whatever, so you can send requests with a second parameter for this basic auth(still better than nothing), so other people cant break you systems, by sending random http requests.

(I just want to make a reactor controller app for android, would be so much satisfaction to do, pls add)

@rubensworks rubensworks changed the title [Request] Token/password protected http proxy Token/password protected http proxy Jul 14, 2018
@rubensworks
Copy link
Member

This would definitely be interesting to have.

I have a huge list of feature request before this though, so don't expect this anytime soon. PRs are welcome though.

@otakup0pe
Copy link

I've started some work on this. Do y'all have any feelings on how it is implemented? Off the top of my head I'm thinking....

  • New string config param apiToken. Defaults to blank which preserves existing behavior.
  • Somewhere around here check to see if the apiToken is not blank. If it's not then check for the X-IntegratedRest-Token header and compare. Proceed as normal if it matches, throw a 403 if it does not.

@rubensworks
Copy link
Member

rubensworks commented Jul 29, 2020

I had in mind to use HTTP's basic authentication protocol: https://en.wikipedia.org/wiki/Basic_access_authentication
Should be supported already by most HTTP server-side and client-side libraries.

@otakup0pe
Copy link

Aite I'll go with basic auth. Do we want to support multiple users / .htpasswd style or just a single user/pass in the config?

@rubensworks
Copy link
Member

I would suggest multiple users directly in the config. Should be easy to implement as a map or list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Options
Development

No branches or pull requests

3 participants