foundry-defi-stablecoin-f23 TransferOwnership Failed

[badar-chachar]

constructor() ERC20("DecentralizedStableCoin", "DSC") {}
this line produces following warning.
No arguments passed to the base constructor. Specify the arguments or mark "DecentralizedStableCoin" as abstract.solidity(3415)

After adding arguments to constructor like this:
constructor(address _owner, string memory _name, string memory _symbol) ERC20(_name, _symbol) Ownable(_owner) {}
the problem is resolved but when the token is created DeployDSC is set as owner and when the ownership is transfered to DSCEngine it gives error.

code snippet of DeployDSC

        vm.startBroadcast();
        DecentralizedStableCoin dsc = new DecentralizedStableCoin(address(this), "DecentralizedStableCoin", "DSC");
        DSCEngine engine = new DSCEngine(tokenAddresses, priceFeedAddresses, address(dsc));
        dsc.transferOwnership(address(engine));
        vm.stopBroadcast();

The error is below:

Ran 1 test for test/unit/DSCEngineTest.t.sol:DSCEngineTest
[FAIL. Reason: setup failed: OwnableUnauthorizedAccount(0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38)] setUp() (gas: 0)
Traces:
  [8036347] DSCEngineTest::setUp()
    ├─ [3634780] → new DeployDSC@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 18043 bytes of code
    ├─ [4359729] DeployDSC::run()
    │   ├─ [3007416] → new HelperConfig@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [372255] → new MockV3Aggregator@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [449186] → new ERC20Mock@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   └─ ← [Return] 2018 bytes of code
    │   │   ├─ [372255] → new MockV3Aggregator@0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [449186] → new ERC20Mock@0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76
    │   │   │   └─ ← [Return] 2018 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Return] 5377 bytes of code
    │   ├─ [912] HelperConfig::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76], MockV3Aggregator: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    │   ├─ [0] VM::startBroadcast()
    │   │   └─ ← [Return] 
    │   ├─ [592138] → new DecentralizedStableCoin@0x50EEf481cae4250d252Ae577A09bF514f224C6C4
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f])
    │   │   └─ ← [Return] 2608 bytes of code
    │   ├─ [522608] → new DSCEngine@0x62c20Aa1e0272312BC100b4e23B4DC1Ed96dD7D1
    │   │   └─ ← [Return] 1932 bytes of code
    │   ├─ [615] DecentralizedStableCoin::transferOwnership(DSCEngine: [0x62c20Aa1e0272312BC100b4e23B4DC1Ed96dD7D1])
    │   │   └─ ← [Revert] OwnableUnauthorizedAccount(0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38)
    │   └─ ← [Revert] OwnableUnauthorizedAccount(0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38)
    └─ ← [Revert] OwnableUnauthorizedAccount(0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38)

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 4.13ms (0.00ns CPU time)

Ran 1 test suite in 43.36ms (4.13ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/unit/DSCEngineTest.t.sol:DSCEngineTest
[FAIL. Reason: setup failed: OwnableUnauthorizedAccount(0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38)] setUp() (gas: 0)

any suggestions for resolution?

[EngrPips]

Hello @badar-chachar, Below is what my DeployDSCEngine.sol script that works fine looks like.

// SPDX-License-Identifier: UNLICENSED
pragma solidity 0.8.23;

import {Script, console2} from "forge-std/Script.sol";
import {HelperConfig} from "./HelperConfig.s.sol";
import {DecentralizedStableCoin} from "../src/DecentralizedStableCoin.sol";
import {DSCEngine} from "../src/DSCEngine.sol";

contract DeployDSCEngine is Script {
    DecentralizedStableCoin decentralized_stable_coin;
    DSCEngine dsc_engine;

    address[] private address_of_collateral_tokens;
    address[] private address_of_collateral_token_price_feeds;

    function run() external returns (DecentralizedStableCoin, DSCEngine, HelperConfig) {
        decentralized_stable_coin = new DecentralizedStableCoin();

        HelperConfig helper_config = new HelperConfig();
        (
            address wETH_token_address,
            address wBTC_token_address,
            address wETH_token_addres_price_feed,
            address wBTC_token_addres_price_feed,
            uint256 deployer_key
        ) = helper_config.active_network_config();

        address_of_collateral_tokens = [wETH_token_address, wBTC_token_address];
        address_of_collateral_token_price_feeds = [wETH_token_addres_price_feed, wBTC_token_addres_price_feed];

        vm.startBroadcast(deployer_key);
        dsc_engine = new DSCEngine(
            address_of_collateral_tokens, address_of_collateral_token_price_feeds, address(decentralized_stable_coin)
        );
        vm.stopBroadcast();

        decentralized_stable_coin.transferOwnership(address(dsc_engine));

        return (decentralized_stable_coin, dsc_engine, helper_config);
    }
}

Can you please show me yours?

[badar-chachar]

sure, this is my DeployDSC code

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.18;

import {Script} from "forge-std/Script.sol";
import {DecentralizedStableCoin} from "../src/DecentralizedStableCoin.sol";
import {DSCEngine} from "../src/DSCEngine.sol";
import {HelperConfig} from "./HelperConfig.s.sol";

contract DeployDSC is Script {
    address[] public tokenAddresses;
    address[] public priceFeedAddresses;

    function run() external returns (DecentralizedStableCoin, DSCEngine, HelperConfig) {
        HelperConfig config = new HelperConfig();

        (
            address wethAddress,
            address wethUsdPriceFeedAddress,
            address wbtcAddress,
            address wbtcUsdPriceFeedAddress,
            uint256 deployerKey
        ) = config.activeNetworkConfig();

        tokenAddresses = [wethAddress, wbtcAddress];
        priceFeedAddresses = [wethUsdPriceFeedAddress, wbtcUsdPriceFeedAddress];

        vm.startBroadcast();
        DecentralizedStableCoin dsc = new DecentralizedStableCoin(address(this), "DecentralizedStableCoin", "DSC");
        DSCEngine engine = new DSCEngine(tokenAddresses, priceFeedAddresses, address(dsc));
        dsc.transferOwnership(address(engine));
        vm.stopBroadcast();
        return (dsc, engine, config);
    }
}

[EngrPips]

Remove this line of code dsc.transferOwnership(address(engine)); from inside the vm.startBroadcast() and vm.stopBroadcast() and let's see if the test would still error.

[badar-chachar]

Well doing this resolved the error and test run successfully. What am i missing here?

[EngrPips]

You were pranking the anvil blockchain's defaultPrivateKey when you called the transferOwnership function on dsc, and the dsc is indeed owned by the DeployDSC script and not the anvil defaultPrivateKey.

[badar-chachar]

okay. thanks. i am gonna carry on the lecture.

[EngrPips]

Fantastic, Keep crushing it, friend.

[farman1094]

I was also getting error in this

**Ran 1 test for test/unit/DSCEngineTest.t.sol:DSCEngineTest
[FAIL. Reason: setup failed: OwnableInvalidOwner(0x0000000000000000000000000000000000000000)] setUp() (gas: 0)
Traces:
  [7669204] DSCEngineTest::setUp()
    ├─ [4038904] → new DeployDSC@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 20061 bytes of code
    ├─ [3587913] DeployDSC::run()
    │   ├─ [3339508] → new HelperConfig@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return]
    │   │   ├─ [372255] → new MockV3Aggregator@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [516505] → new ERC20Mock@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2117 bytes of code
    │   │   ├─ [372255] → new MockV3Aggregator@0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [516505] → new ERC20Mock@0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2117 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return]
    │   │   └─ ← [Return] 6360 bytes of code
    │   ├─ [912] HelperConfig::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], MockV3Aggregator: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    │   ├─ [0] VM::startBroadcast(<pk>)
    │   │   └─ ← [Return]
    │   ├─ [45275] → new <unknown>@0x5FbDB2315678afecb367f032d93F642f64180aa3
    │   │   └─ ← [Revert] OwnableInvalidOwner(0x0000000000000000000000000000000000000000)
    │   └─ ← [Revert] OwnableInvalidOwner(0x0000000000000000000000000000000000000000)
    └─ ← [Revert] OwnableInvalidOwner(0x0000000000000000000000000000000000000000)

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 4.57ms (0.00ns CPU time)

Ran 1 test suite in 1.52s (4.57ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/unit/DSCEngineTest.t.sol:DSCEngineTest
[FAIL. Reason: setup failed: OwnableInvalidOwner(0x0000000000000000000000000000000000000000)] setUp() (gas: 0)**

But my issue has been resolved by making the change in DecentralizedStableCoin

        //change here 0x0 to msg.sender ///
    // constructor() ERC20("DecentralizedStableCoin", "DSC") Ownable(address(0)) {}
    constructor() ERC20("DecentralizedStableCoin", "DSC") Ownable(msg.sender) {}

wtihout making any changes in DSCDepoly

[EngrPips]

You are a genius, Thanks for this heads-up.