Section 4: Smart Contract Lottery make deploy-sepolia

[KrisAdw]

This is my first time asking in discussion, hopefully it will be answered.

So, in my lesson I tried to deploy smart contract lottery to testnet using make, the script is run successfully but it didn't request any keystore password for the --account of my wallet as usually.

make deploy-sepolia 
[⠒] Compiling...
No files changed, compilation skipped
Traces:
  [120] DeployRaffle::run()
    └─ ← [Stop] 


Script ran successfully.

I already add sepolia rpc and etherscan api key, also have my dynamic private key into cast wallet named sepoliaKey. But it didn't request any keystore. Here is my makefile:

-include .env

.PHONY: all test deploy

build :; forge build

test :; forge test

install :; forge install cyfrin/[email protected] --no-commit && forge install smartcontractkit/[email protected] --no-commit && forge install foundry-rs/[email protected] --no-commit && forge install transmissions11/solmate@v6 --no-commit

deploy-sepolia:
	@forge script script/DeployRaffle.s.sol:DeployRaffle --rpc-url $(SEPOLIA_RPC_URL) --account sepoliaKey --broadcast --verify --etherscan-api-key $(ETHERSCAN_API_KEY) -vvvv

I also tried to run manually in terminal without makefile, it turn out to be the same output. I doing it the same like the Fund Me contract, but it run normally in fund me contract. Or maybe the problem is in the deploy script?

// SPDX-License-Identifier: SEE LICENSE IN LICENSE
pragma solidity 0.8.19;

import { Script } from "forge-std/Script.sol";
import { Raffle } from "../src/Raffle.sol";
import { HelperConfig } from "./HelperConfig.s.sol";
import {CreateSubscription, FundSubscription, AddConsumer} from "./Interaction.s.sol";

contract DeployRaffle is Script {
    function run() public {}

    function deployContract() public returns(Raffle, HelperConfig){
        HelperConfig helperConfig = new HelperConfig();
        // if local -> deploy mocks, get local config
        // if sepolia -> get sepolia config
        HelperConfig.NetworkConfig memory config = helperConfig.getConfig();

        if(config.subscriptionId == 0){
            // Create subcription
            CreateSubscription createSubscription = new CreateSubscription();
            (config.subscriptionId, config.vrfCoordinator) = createSubscription.createSubscription(config.vrfCoordinator, config.account);

            // Fund subscription
            FundSubscription fundSubscription = new FundSubscription();
            fundSubscription.fundSubscription(config.vrfCoordinator, config.subscriptionId, config.link, config.account);

        }

        vm.startBroadcast(config.account);
        Raffle raffle = new Raffle(
            config.entranceFee,
            config.interval,
            config.vrfCoordinator,
            config.gasLane,
            config.subscriptionId,
            config.callbackGasLimit
        );
        vm.stopBroadcast();

        AddConsumer addConsumer = new AddConsumer();
        addConsumer.addConsumer(address(raffle), config.vrfCoordinator, config.subscriptionId, config.account);
        return (raffle, helperConfig);
    }
}

That is my question, any help will be appreciated

[EngrPips]

Hello @KrisAdw, Have you figured this out already?

[KrisAdw]

Yesss i have, it's just that my function run is empty and didn't call the deploy contract function :) thankyou for asking

…

On Thu, Sep 5, 2024 at 2:16 PM EngrPips ***@***.***> wrote: Hello @KrisAdw <https://github.com/KrisAdw>, Have you figured this out already? — Reply to this email directly, view it on GitHub <#2397 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXT5T3AHR6PUWGMKMKLDAYTZVAAL3AVCNFSM6AAAAABNVS6SW2VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTANJVGQYDIMY> . You are receiving this because you were mentioned.Message ID: <Cyfrin/foundry-full-course-cu/repo-discussions/2397/comments/10554043@ github.com>

[EngrPips]

Awesome, I am glad you figured it out. Keep crushing it.