Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doing] use "PeerID" replace "ESSE ID & PeerID". #15

Closed
sunhuachuang opened this issue Jan 24, 2022 · 1 comment
Closed

[Doing] use "PeerID" replace "ESSE ID & PeerID". #15

sunhuachuang opened this issue Jan 24, 2022 · 1 comment

Comments

@sunhuachuang
Copy link
Member

sunhuachuang commented Jan 24, 2022

Now, if you search a friend, you need to know ESSE ID and PeerID.
How about only use PeerID ?

Advantages

  1. Easy to understand
  2. User info is smaller
  3. Easy to handle network connect/disconnect

Disadvantages

  1. Can't at same time online multiple accounts. (one account is one PeerID)
  2. Login before network start
  3. Logout will make network stop
  4. Change account, restart network
  5. Difficult to identify whether connecting to cloud service

Step

  1. chamomile support stop network, restart network, and TDN also add
  2. Refactor account system

How

use new ID (string)

pub fn id(peer: &tdn_types::primitive::PeerId) -> String {
    bs32::encode(&peer.0)
}
@sunhuachuang sunhuachuang changed the title [TBD] use "PeerID" replace "ESSE ID & PeerID". [Doing] use "PeerID" replace "ESSE ID & PeerID". Mar 18, 2022
@sunhuachuang
Copy link
Member Author

I think it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant