needles check? itemholder

[SwissalpS]

I don't see where the item meta field is ever set:

scifi_nodes/nodeboxes.lua

Line 1111 in 1558b4c

if meta:get_string("item") ~= "" then

on_destruct() seems pointless.

Did I overlook something?

itemframes and pedestals set that value [homedecor_modpack/itemframes] but sci_fi stands do not.
Also itemframes and pedestals protect their items while sci_fi counterparts give free gifts, behaviour which I like.

[SwissalpS]

actually setting the 'item' field would make replacer:inspect more accurate, but it doesn't depend on it.

While testing I encountered another odity:
works best with powered_stand, itemholder does this too but seems not as much.

• place two stands next to each other.
• put an item on each
• often the second item will go join the first.

This is core stacking nearby entities at work.
The work-around would be to add unstackable entity like pedestals do.

Edit: I think the time interval between placing the items has an influence.
It also seems that the items are then timed-out after a while, because I have empty stands some time after doing this.

[BuckarooBanzay]

Did I overlook something?

nope, this looks pointless... 👍

Also, fyi: https://github.com/pandorabox-io/pandorabox_custom/blob/22a83072a4a8456c9689e178387b380d1e68c0f2/scifi_override.lua#L155

And the discussion in #22 about the itemstand overhaul

[SwissalpS]

Thanks, yes the 'insta-repair-patch' does fix all these issues and more.