Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support active_threshold in dao-voting-cw4 #781

Open
JakeHartnell opened this issue Dec 11, 2023 · 2 comments
Open

Support active_threshold in dao-voting-cw4 #781

JakeHartnell opened this issue Dec 11, 2023 · 2 comments
Labels
good-first-issue Issue that is good for first. improvement adds a new feature

Comments

@JakeHartnell
Copy link
Member

JakeHartnell commented Dec 11, 2023

As a DAO, we would like to have SubDAOs where there needs to be a minimum number of members for the SubDAO to be active.

We support active_threshold for NFTs and token-based DAOs, might as well make it supported in membership / multisig based DAOs.

@JakeHartnell JakeHartnell added the improvement adds a new feature label Dec 11, 2023
@JakeHartnell JakeHartnell added the good-first-issue Issue that is good for first. label Feb 20, 2024
@theghostmac
Copy link

Hi @JakeHartnell,

I have just added this in my fork, and will make a PR in a moment. However, I want to verify that there will be need to:

  • Query SubDAOs based on active/inactive status.
  • Enforce rules for active/inactive SubDAOs and implement checks based on the status, maybe during proposal creation or voting etc to ensure only active SubDAOs can participate.
  • Adding and removing SubDAO members
  • Automatically toggle a SubDAO status based on amount of members >= active threshold.

Just a checklist we may have to include to this new feature...

@JakeHartnell
Copy link
Member Author

To be clear, the contract that needs to be modified is contracts/voting/dao-voting-cw4. There are examples of implementing active threshold in contracts/voting/dao-voting-cw721-staked and contracts/voting/dao-voting-token-staked, use those for reference. Both of those examples, show the queries that need to be implemented, namely a QueryMsg::IsActive query.

Many of the features you listed are not actually needed for this as these features are handled via the voting module contract (i.e. dao-voting-cw4).

theghostmac added a commit to theghostmac/dao-contracts that referenced this issue Apr 6, 2024
theghostmac added a commit to theghostmac/dao-contracts that referenced this issue Apr 7, 2024
theghostmac added a commit to theghostmac/dao-contracts that referenced this issue Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Issue that is good for first. improvement adds a new feature
Projects
None yet
Development

No branches or pull requests

2 participants