You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To retreive the water levels of a state using it's property, a double conversion is happening, such that the returned value represents the sensor distance and not the water level.
where self.Tube1_sonar_dist_mm is already a converted value.
One could also argue that when the sensor data is fetched by update_state(), no conversion should be performed, as the data currently written into self.Tube1_sonar_dist_mm does not match what the property name suggests.
The text was updated successfully, but these errors were encountered:
I decided to remove the conversion when the a new state information is retreived. In that way, the property names in the ClaireState correspond to the stored value.
To retreive the water levels of a state using it's property, a double conversion is happening, such that the returned value represents the sensor distance and not the water level.
For example
where
self.Tube1_sonar_dist_mm
is already a converted value.One could also argue that when the sensor data is fetched by
update_state()
, no conversion should be performed, as the data currently written intoself.Tube1_sonar_dist_mm
does not match what the property name suggests.The text was updated successfully, but these errors were encountered: