Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First instance normalization is not utilized in 'ConvODEFunc' for the time dependent case #7

Open
akgokce opened this issue Apr 23, 2020 · 1 comment

Comments

@akgokce
Copy link

akgokce commented Apr 23, 2020

Hey guys, thanks for the great work. I have an ongoing project dealing with NODE networks and your repository helped me a lot.

I was reading the code thoroughly to understand your network structure, then I realized that in models.py line 38 the output of the first instance normalization is not used in the following operations. Is this an intended usage or is it bug?

Thanks in advance!

out = self.conv1(t, x)

@akgokce akgokce changed the title First instance normalization is not utilized in 'ConvODEFunc' for time dependent case First instance normalization is not utilized in 'ConvODEFunc' for the time dependent case Apr 23, 2020
@akgokce akgokce changed the title First instance normalization is not utilized in 'ConvODEFunc' for the time dependent case First instance normalization is not utilized in 'ConvODEFunc' for the the time dependent case Apr 23, 2020
@akgokce akgokce changed the title First instance normalization is not utilized in 'ConvODEFunc' for the the time dependent case First instance normalization is not utilized in 'ConvODEFunc' for the time dependent case Apr 23, 2020
@hanspinckaers
Copy link
Collaborator

Hi, thanks for noticing! This was unintended, but I did train the model with this bug. Would be interesting to see if performance increases with the normalization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants