Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Rendered Message When 'Feedback Request' is Successfully Sent on a Plan #3370

Open
aaronskiba opened this issue Jan 24, 2024 · 0 comments

Comments

@aaronskiba
Copy link
Contributor

aaronskiba commented Jan 24, 2024

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

  • v4.1.1

Explanation
Rather than receiving a generic success message, the rendered notice is a copy of the feedback request message.

  • Screenshot 2024-01-24 at 1 39 00 PM

I'm not sure exactly if or how we should address this. Maybe the success message notification can be kept, but the Your plan "{plan_name}" has been submitted... message rendered within the body of the page (see below image) should be removed?

  • Screenshot from 2024-02-05 08-20-10

Corresponding Code

  # Flash notice for successful feedback requests
  #
  # Returns String
  def request_feedback_flash_notice
    # Use the generic feedback confirmation message unless the Org has
    # specified one
    text = current_user.org.feedback_msg || feedback_confirmation_default_message
    feedback_constant_to_text(text, current_user, @plan, current_user.org)
  end
@aaronskiba aaronskiba changed the title Improve Rendered Message When 'Feedback Request' is Successfully Sent on a Plan Address Rendered Message When 'Feedback Request' is Successfully Sent on a Plan Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant