Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need proper handling of partially corrupted data #7

Open
ylin00 opened this issue Aug 15, 2020 · 3 comments
Open

Need proper handling of partially corrupted data #7

ylin00 opened this issue Aug 15, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ylin00
Copy link
Collaborator

ylin00 commented Aug 15, 2020

No description provided.

@thcasey3
Copy link
Member

The two most common issues and potential solutions:

  1. T1(0) ends up more than T1,0(0) or the user forgets to update the T1,0(0) they input. This is easy to find with ValueError and display message before the calculations are even attempted
  2. The first T1(p) point is bad, give checkbox option to exclude it or have the fit automatically check if it differs from the remaining four far more than they differ from each other and if so exclude it from the fit and run again

@ylin00
Copy link
Collaborator Author

ylin00 commented Aug 19, 2020

Item 1 is a new feature to do.
Item 2 has been added in v1.2

@ylin00 ylin00 added the enhancement New feature or request label Aug 19, 2020
@ylin00
Copy link
Collaborator Author

ylin00 commented Aug 30, 2020

Warnings of T1(0) > T1,0(0) were added in v1.3. Issue #1 needs to be solved first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ylin00 @thcasey3