Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube::fromIsd doesn't add LineScanTimes table for HRSC Isds #5668

Closed
amystamile-usgs opened this issue Nov 12, 2024 · 3 comments · Fixed by #5705
Closed

Cube::fromIsd doesn't add LineScanTimes table for HRSC Isds #5668

amystamile-usgs opened this issue Nov 12, 2024 · 3 comments · Fixed by #5705
Assignees
Labels
bug Something isn't working

Comments

@amystamile-usgs
Copy link
Contributor

I tried to create an HRSC camera fixture with an ISD but ran into errors that the camera model could not find the LineScanTimes table. Looks like Cube::fromIsd only adds Spice table data and not any additional tables that may be in the ISD.

@amystamile-usgs amystamile-usgs added the bug Something isn't working label Nov 12, 2024
@amystamile-usgs amystamile-usgs self-assigned this Jan 3, 2025
@amystamile-usgs amystamile-usgs moved this from Todo to In Progress in Astro Software Support Sprint Jan 3, 2025
@amystamile-usgs
Copy link
Contributor Author

I made progress on this and then realized that the line_scan_rates from the isd do not match the data from the LineScanTimes table. I am not sure if they are suppose to. So overall, I am not sure if we should be pulling this info from the isd or grabbing the table from the original cube when running Cube::fromIsd.

See Ale Issue: DOI-USGS/ale#629

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Jan 6, 2025

If the tables do not match that is a problem. ALE bug?

@amystamile-usgs
Copy link
Contributor Author

Adam responded to my ale issue and said it's intentional for USGSCSM. I think instead of trying to pull this data from the isd, we should just make sure the table is getting copied over from the original cube—right now, it’s not for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants