Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jigsaw - applied H5 adjustment information does not match regular bundle updates #5701

Open
lwellerastro opened this issue Jan 2, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lwellerastro
Copy link
Contributor

lwellerastro commented Jan 2, 2025

ISIS version(s) affected: 9.0.0 RC1

Description
There is no documentation to reference at the moment, so maybe I'm just not running any of this correctly, but trial and error has gotten me to the conclusion that images using H5 adjustment files do not match images bundled and updated via jigsaw through normal procedures (without the new OUTADJUSTMENTH5 file).

There are a number of changes to how jigsaw runs with new functions that are not super intuitive to the user so again, maybe I'm just not running any of this properly. But the program is pretty clear in that it does not want my network, does not want update=yes (except it is updating the data), pretty much doesn't want anything but the list of images and an H5 file.

Basic steps (detail below):

  • jigsaw update=no outadjustmenth5=yes
  • jigsaw adjustment_input=file.h5
    • caminfo on adjusted images
  • jigsaw update=yes on same network
    • caminfo on updated images
  • compare caminfo files

How to reproduce
Data are under my work users area Isis3Tests/Jigsaw/I900RC1_HD5Format/

ApplySavedValues/ - create and apply H5 file to images under ApplySavedValues/Lev0/

jigsaw fromlist=KTC_small.lis cnet=KTC_small.net \
onet=JigOut_KTC_small_HD5.net \
radius=yes update=no \
sigma0=1.0e-10 maxits=10 \
camsolve=accelerations twist=yes overexisting=yes \
spsolve=position overhermite=yes \
spacecraft_position_sigma=1000 \
camera_angles_sigma=0.25 camera_angular_velocity_sigma=0.1 camera_angular_acceleration_sigma=0.01 \
point_radius_sigma=100 \
outadjustmenth5=true \
file_prefix=RadAccelTwistSpk_HDF5

Bundle has converged
Bundle Complete
Generating report files
  Group = JigsawResults
    Status = "Camera pointing NOT updated"
  End_Group


jigsaw fromlist=updated_KTC_small.lis adjustment_input=RadAccelTwistSpk_HDF5_adjustment_out.h5
  Group = JigsawResults
    Status = "Bundle adjustment values from
              [RadAccelTwistSpk_HDF5_adjustment_out.h5] were applied to the
              cubes in [KTC_small.lis]"
  End_Group

egrep -a Jig Lev0/TC2W2B0_01_07031N307E0597.lev0.cub
# JigApplied = 2025-01-02T16:14:18
# JigApplied = 2025-01-02T16:14:18

Also of note -  Polygon Object is still on image though that is normally removed when bundling and updating which would be expected since we have new information and what was present was based on spice.

caminfo from=Lev0/TC2W2B0_01_07031N307E0597.lev0.cub to=jigApplied_TC2W2B0_01_07031N307E0597.lev0.pvl geometry=true isislabel=true camstats=true linc=100 sinc=100 polygon=true polylinc=100 polysinc=100

caminfo from=/PathToOriginalSpice/TC2W2B0_01_07031N307E0597.lev0.cub to=origspice_TC2W2B0_01_07031N307E0597.lev0.pvl geometry=true isislabel=true camstats=true linc=100 sinc=100 polygon=true polylinc=100 polysinc=100

These file differ quite a bit which is to be expected, but some keywords are extremely different particularly in regard to the spacecraft:

egrep SubSpacecraftAzimuth origspice_TC2W2B0_01_07031N307E0597.lev0.pvl jigApplied_TC2W2B0_01_07031N307E0597.lev0.pvl 
   origspice_TC2W2B0_01_07031N307E0597.lev0.pvl:    SubSpacecraftAzimuth       = 83.962039353372
   jigApplied_TC2W2B0_01_07031N307E0597.lev0.pvl:    SubSpacecraftAzimuth       = 311.03412503115

RegularUpdate/ - bundle and update images under RegularUpdate/Lev0/

Same images (list name different, but it's the same spiced images as input), network and bundle:

jigsaw fromlist=updated_KTC_small.lis cnet=KTC_small.net \
onet=JigOut_KTC_small_updated.net \
radius=yes update=yes \
sigma0=1.0e-10 maxits=10 \
camsolve=accelerations twist=yes overexisting=yes \
spsolve=position overhermite=yes \
spacecraft_position_sigma=1000 \
camera_angles_sigma=0.25 camera_angular_velocity_sigma=0.1 camera_angular_acceleration_sigma=0.01 \
point_radius_sigma=100 \
outadjustmenth5=no \
file_prefix=RadAccelTwistSpk

  Group = JigsawResults
    Status = "Camera pointing updated"
  End_Group

egrep -a Jig Lev0/TC2W2B0_01_07031N307E0597.lev0.cub
# Jigged = 2025-01-02T13:50:44
# Jigged = 2025-01-02T13:50:44

caminfo from=Lev0/TC2W2B0_01_07031N307E0597.lev0.cub to=jigUpdated_TC2W2B0_01_07031N307E0597.lev0.pvl geometry=true isislabel=true camstats=true linc=100 sinc=100 polygon=true polylinc=100 polysinc=100

meld jigUpdated_TC2W2B0_01_07031N307E0597.lev0.pvl ../ApplySavedValues/jigApplied_TC2W2B0_01_07031N307E0597.lev0.pvl &

Very different answers. Also note that the polygon and camera statistics tables have been removed from the jigsaw updated images.

JigsawUpdated_vs_H5Applied

The Instrument Pointing and Position table contents are different as well:
JigsawUpdated_vs_H5Applied_InstrumentPointingTable

JigsawUpdated_vs_H5Applied_InstrumentPositionTable

Maybe that's the real problem.

@lwellerastro lwellerastro added the bug Something isn't working label Jan 2, 2025
@chkim-usgs chkim-usgs self-assigned this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants