Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control network to_isis and from_isis expect different column names in the df #121

Closed
jessemapel opened this issue Jun 19, 2019 · 4 comments
Labels

Comments

@jessemapel
Copy link
Contributor

The from_isis method creates a df with column names that match the ISIS protobuf spec. The to_isis method expects a df with different column names. This means you cannot do the following:

df = from_isis(`some.net`)
do things to df
to_isis(df, `some_modified.net`)
@jessemapel
Copy link
Contributor Author

This may be the cause of #111

@jlaura jlaura added the bug label Jun 19, 2019
@jlaura
Copy link
Collaborator

jlaura commented Jun 19, 2019

Labelled as a bug since we should be able to roundtrip inside of plio. Consumers of plio that need to do formatting should be doing that formatting locally.

@acpaquette
Copy link
Collaborator

@jessemapel Looks like the case you outlined in the original issue was fixed by #131. However the split between measure columns and point columns outlined in #122 may no longer be present

@jessemapel
Copy link
Contributor Author

That is a problem then. There are fields on the measures and points that have the same name. if they don't have the prefixes any more then things are not going to write out correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants