Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame camera throws out-of-bounds exception #489

Open
oleg-alexandrov opened this issue Jan 27, 2025 · 0 comments
Open

Frame camera throws out-of-bounds exception #489

oleg-alexandrov opened this issue Jan 27, 2025 · 0 comments

Comments

@oleg-alexandrov
Copy link
Collaborator

The frame camera model code throws an exception when it is asked to find the sensor position and velocity when the input pixel is a bit outside of the image domain. This is for functions UsgsAstroFrameSensorModel::getSensorPosition() and getSensorVelocity().

This is not desirable behavior. It is possible for a ground point to project into the camera at a pixel outside of the image box. The software should be able to return the sensor position and velocity for such a pixel, which is the same for all pixels anyway, for a frame camera.

This check is not present for linescan cameras, which graciously does the best it can. It clamps the input pixel line to the range of lines it can handle.

Such behavior as for the frame camera is problematic as it requires fixes in software that functions perfectly fine with other camera implementations, including outside of usgscsm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant