Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecated methods to make DXL ready for 1.13 #333

Closed
10 of 18 tasks
Sataniel98 opened this issue Nov 16, 2017 · 4 comments
Closed
10 of 18 tasks

Get rid of deprecated methods to make DXL ready for 1.13 #333

Sataniel98 opened this issue Nov 16, 2017 · 4 comments
Assignees
Milestone

Comments

@Sataniel98
Copy link
Member

Sataniel98 commented Nov 16, 2017

Get rid of:

  • Old Material enum values
  • Block data values
    • LockedDoor
    • TeamFlag
    • PlaceableBlock
    • RedstoneTrigger
    • BlockSign
    • DEditPlayer
    • DPortal
    • GameSign
    • GroupSign
  • Entity#fromName() etc.
    • MobSpawnTask
    • DMob
  • Old SkeletonType
    • DMobType
    • MobSpawnTask
  • LivingEntity#getMaxHealth(); LivingEntity#setMaxHealth(double health)
    • DGamePlayer
    • DGlobalPlayer
    • DInstancePlayer
    • DPlayerData
    • DMobType

1.8 compatibility:

  • EntityEquipmanet/HumanEntity#getItemInHand(); EntityEquipmanet/HumanEntity#setItemInHand(ItemStack item); ...
    • DGamePlayer
    • PortalCommand
    • GlobalProtectionListener
    • DMobType
    • DMob
    • MobSpawnTask
  • Magic value dye
    • DColor#getWoolData()
    • TeamFlag
      DVs:
  • Numeric material IDs
    • PlaceableBlock
    • HologramSign
    • BlockSign
    • DMobType
  • Remove /dxl deleteportal command (-> /dxl break)
  • Remove MythicMobs signs (-> ExternalMob)
  • Remove support for 1.7.x and 1.8.x (-> 1.9+ :P)

Do not get rid of:

  • Bukkit#getOfflinePlayer(String name) - No replacement available; not likely to get remove
  • Internal deprecated methods - That's to be done later
@Sataniel98 Sataniel98 added this to the Beta 0.16-HOTFIX milestone Nov 16, 2017
@Sataniel98 Sataniel98 self-assigned this Nov 16, 2017
@Tiplish
Copy link
Contributor

Tiplish commented Jan 23, 2018

Hi,

Is it the all list that you have identified as main incompatibility with the next Minecraft update and DXL? Or there could be a lot of unidentified incompatibility due to the 1.13?

@Sataniel98
Copy link
Member Author

I did this in November; about two months before the first API preview was published. Thus, it's completely speculative. I'm almost sure that's everything though, and even if it's not, further breakages wouldn't increase the work load significantly. To be honest, testing the affected things with all of the versions it's supposed to work with is likely to be more of a hassle than the actual programming. The update may be huge for Spigot and Minecraft from a technical point of view, but it really isn't much trouble for DXL. Spigot will provide some legacy support, so DXL might work fine without any adjustments at all. But even then, I'll clean the code up a bit.

@Tiplish
Copy link
Contributor

Tiplish commented Jan 24, 2018

Great news, thanks for information :) i'm developper too and i've seen a lot of technical chance/add in the 1.13 vers but i wasn't able to figure how it will impacte development and so, the delay before a release of our favorite plugin whith 1.13 support.

Have a nice day o/

Sataniel98 added a commit that referenced this issue Jan 24, 2018
@Sataniel98
Copy link
Member Author

This commit resolves a good bit. However, I still need to do something in regard to usage of block DVs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants