Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sure Install Instructions are Clear and Intuitive #1

Open
navila-luna opened this issue Jun 27, 2023 · 5 comments
Open

Make Sure Install Instructions are Clear and Intuitive #1

navila-luna opened this issue Jun 27, 2023 · 5 comments
Assignees
Labels
dedupliFHIR DedupliFHIR repo tickets documentation Improvements or additions to documentation summer2024 Tickets for Summer 2024 Fellowship Cohort

Comments

@navila-luna
Copy link

Make install does not install all required packages to run the program. New users are not informed that they need to create a virtual environment, install flask, install poetry, and install dedupe. The following are the exact commands I wrote to successfully run make start without an error message, you need to run the following steps:

  1. Create a virtual environment and activate the environment
    • $ python3 -m venv .venv
    • . .venv/bin/activate
  2. Install Flask: pip3 install flask
  3. (mac) brew install poetry
  4. Install dedupe: pip3 install dedupe

Note these are the commands that worked on my M1 computer.

@navila-luna navila-luna added the documentation Improvements or additions to documentation label Jun 27, 2023
@navila-luna navila-luna self-assigned this Jun 27, 2023
@Gaelan
Copy link

Gaelan commented Jun 27, 2023

I'm not too familiar with Python stuff, but I think Poetry's supposed to manage the venv+dependencies for you. So you just install Poetry (following the instructions at https://python-poetry.org/docs/#installation), then just do poetry shell to get into a venv with the necessary stuff.

@Gaelan
Copy link

Gaelan commented Jun 27, 2023

Oops, I see you already installed poetry through brew, so yeah poetry shell should be all you need.

Documenting this is a good idea!

@navila-luna
Copy link
Author

Hello Gaelan, currently the make file only runs the poetry file which does not include flask installation. So if you do not have flask installed you need to create a virtual instrument and then install flask. This is also noted in the README that poetry requires flask installation. The steps I listed above are the ones I did in order to run the program. However, I understand there may be different ways of producing the same results. Feel free to list what worked for you.

@IsaacMilarky IsaacMilarky changed the title Considering Changing Installation Steps On ReadMe for Newcomers Make Sure Install Instructions are Clear and Intuitive Nov 9, 2023
@IsaacMilarky
Copy link
Collaborator

There is no reason why we can't install the program with make install.

We plan to switch to an electron app anyways and that stack can just be pointed towards a python virtual environment. We should have the makefile create or use an existing python virtual environment that is passed in via an environment variable or prompted via a shell script.

@IsaacMilarky
Copy link
Collaborator

Wait until electron app is further along.

@decause-gov decause-gov added dedupliFHIR DedupliFHIR repo tickets summer2024 Tickets for Summer 2024 Fellowship Cohort labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dedupliFHIR DedupliFHIR repo tickets documentation Improvements or additions to documentation summer2024 Tickets for Summer 2024 Fellowship Cohort
Projects
None yet
Development

No branches or pull requests

4 participants