missing implementation in RoleService: hard-coded return values in isController / isAdmin

[saschaszott]

Describe the bug

RoleService provides methods to check whether a given user is submitter / controller / admin. The implementations of both methods isController and isAdmin are missing (TODO comment was added 5 years ago by @atarix83):

dspace-angular/src/app/core/roles/role.service.ts

Line 39 in 779ff47

return observableOf(true);

dspace-angular/src/app/core/roles/role.service.ts

Line 47 in 779ff47

return observableOf(false);

Consequently, every logged-in user has the controller "role" and the dropdown field in "MyDSpace" shows inappropriate option values. The screenshot below shows the options available to the demo user [email protected] (which has only the submitter role):