Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore http/https and anchor differences in URLs #20

Open
DanilaFe opened this issue Jan 15, 2022 · 5 comments
Open

Ignore http/https and anchor differences in URLs #20

DanilaFe opened this issue Jan 15, 2022 · 5 comments

Comments

@DanilaFe
Copy link
Owner

Otherwise, sending someone a link to a sub-section of a page can make them unable to see the highlights.

@gleachkr
Copy link

Is there anything that needs to be done to account for sites that use hash-routing?

@DanilaFe
Copy link
Owner Author

I was wondering the same thing. Even something like matrix.to for instance. I am not sure how to reconcile the two approaches, to be honest.

@gleachkr
Copy link

gleachkr commented Jan 17, 2022

The only thing I can think of is to make it user-configurable, probably with an "ignore anchor differences" default - maybe storing whether this site uses hash-routing in room-state somehow?

@DanilaFe
Copy link
Owner Author

That sounds like a good way of doing it - I wonder where this would be stored, though. Account data? Some kind of matrix highlight space or room? Seems like the latter approach is cleaner.

@gleachkr
Copy link

It does seem like this data should be shared between clients, so yeah, I'd say in the state of whatever matrix-entity is representing the annotation target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants