Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make highlight-messages visible in a normal matrix client #25

Open
Stvad opened this issue Jan 1, 2023 · 4 comments
Open

Make highlight-messages visible in a normal matrix client #25

Stvad opened this issue Jan 1, 2023 · 4 comments

Comments

@Stvad
Copy link
Contributor

Stvad commented Jan 1, 2023

It'd be great if one could see the messages in the normal Matrix client and continue the discussion there!

people in #matrix-highlight:matrix.danilafe.com mentioned that you had some plans to do it @DanilaFe !


I've actually built a quick prototype of this in my fork 🙃

image
image


Architecture-wise I think the "correct" approach would be to rely on extensible events, but I failed to make those actually display in Element. (and they are still in the state of MSC with unclear acceptance date)

So for now prototype shoves everything into content of m.room.message - that worked! :)

Stvad added a commit to Stvad/matrix-highlight that referenced this issue Jan 1, 2023
@Stvad
Copy link
Contributor Author

Stvad commented Jan 1, 2023

lmk if you'd be ok with accepting a PR with that prototype architecture!

@DanilaFe
Copy link
Owner

I would still be interested in this as a PR, particularly if you just modified the existing events sent by matrix highlight to include additional information.

@Stvad
Copy link
Contributor Author

Stvad commented Apr 22, 2023

You can't do that, until Extensible Events is a thing. To be displayed in the normal matrix client, we currently need to pretend to be m.room.message with some custom fields on the side.

In my version this works well, the structure of the data remains the same, and I preserved the backwards compatibility with the old event type

@DanilaFe
Copy link
Owner

I find it quite upsetting that extensible events, unlike other MSCs, do not have an Element implementation. My current plan is to allow matrix highlight to handle message events, and put how it sends highlights behind a setting (toggle between custom event type and m.message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants