Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1410 - SHA1 PCR bank is unusable #819

Closed
pkubaj opened this issue Apr 24, 2024 · 5 comments
Closed

V1410 - SHA1 PCR bank is unusable #819

pkubaj opened this issue Apr 24, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@pkubaj
Copy link

pkubaj commented Apr 24, 2024

Component

Dasharo firmware

Device

other

Dasharo version

0.9.0rc2

Dasharo Tools Suite version

No response

Brief summary

SHA1 PCR bank on V1410 is not usable

How reproducible

No response

How to reproduce

Trying to enable SHA1 PCR bank on V1410 is not working - saving doesn't seem to save the setting.

Expected behavior

SHA1 PCR bank should work corrently

Actual behavior

root@3mdeb:~# tpm2_getcap pcrs
selected-pcrs:
  - sha1: [ ]
  - sha256: [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23 ]

Screenshots

No response

Additional context

No response

Solutions you've tried

No response

@pkubaj pkubaj added the bug Something isn't working label Apr 24, 2024
@pkubaj
Copy link
Author

pkubaj commented Apr 24, 2024

I'm not sure but it might be a reproduction of #521

@miczyg1
Copy link
Contributor

miczyg1 commented Apr 25, 2024

That is one thing, another is that some TPMs no longer enable SHA1 bank by default. The tests should stop assuming SHA1 is always enabled.

@pkubaj
Copy link
Author

pkubaj commented Apr 25, 2024

But some TPMs still provide SHA1 features. Should we then only test for SHA256?

@miczyg1
Copy link
Contributor

miczyg1 commented Apr 25, 2024

The test should verify banks that are currently enabled, unless we explicitly expect to test different bank (that is supported by TPM).

@macpijan
Copy link
Contributor

We have issue on test enrivonment already: Dasharo/open-source-firmware-validation#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants