Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup config warnings #846

Closed
pietrushnic opened this issue Jun 3, 2024 · 6 comments
Closed

Cleanup config warnings #846

pietrushnic opened this issue Jun 3, 2024 · 6 comments

Comments

@pietrushnic
Copy link

Using this procedure from dasharo-pq, I get this:

/home/coreboot/coreboot/.config:1:warning: unknown symbol: PXE_SERIAL_CONSOLE
/home/coreboot/coreboot/.config:19:warning: unknown symbol: PXE_ADD_SCRIPT
/home/coreboot/coreboot/.config:20:warning: unknown symbol: PXE_CUSTOM_BUILD_ID
/home/coreboot/coreboot/.config:22:warning: unknown symbol: PXE_SCRIPT
/home/coreboot/coreboot/.config:24:warning: unknown symbol: SEABIOS_BOOTORDER_IN_FMAP
/home/coreboot/coreboot/.config:29:warning: unknown symbol: SORTBOOTORDER_REVISION
/home/coreboot/coreboot/.config:30:warning: unknown symbol: SORTBOOTORDER_REVISION_ID
/home/coreboot/coreboot/.config:31:warning: unknown symbol: SORTBOOTORDER_SECONDARY_PAYLOAD

Some config options were most likely changed, and others are not yet available at this stage and should be moved to another patch.

@pietrushnic
Copy link
Author

Not supported on the first patch, those changes were added later, so they should not be used at this point:

  • PXE_CUSTOM_BUILD_ID
  • SEABIOS_BOOTORDER_IN_FMAP
  • SORTBOOTORDER_REVISION
  • SORTBOOTORDER_REVISION_ID
  • SORTBOOTORDER_SECONDARY_PAYLOAD

Other required fixes: PXE -> IPXE

Those changes were removed from the config, the warnings were fixed: Dasharo/dasharo-pq@8383a4f

@pietrushnic
Copy link
Author

pietrushnic commented Jun 4, 2024

Some warning return after patch 0032:

/home/coreboot/coreboot/.config:19:warning: unknown symbol: PXE_ADD_SCRIPT
/home/coreboot/coreboot/.config:21:warning: unknown symbol: PXE_SCRIPT

Those should be changed to IPXE_* most probably.

@pietrushnic
Copy link
Author

Fixed: Dasharo/dasharo-pq@db2cef5

@pietrushnic
Copy link
Author

Problem was reintroduced one more time after fixing sortbootorder issues

@pietrushnic
Copy link
Author

Build coreboot for apu2
/home/coreboot/coreboot/.config:20:warning: unknown symbol: PXE_ADD_SCRIPT
/home/coreboot/coreboot/.config:21:warning: unknown symbol: PXE_CUSTOM_BUILD_ID

@pietrushnic
Copy link
Author

No warnings occur on https://github.com/Dasharo/dasharo-pq/tree/24.05.00.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant