Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo 11 Thunderbolt 4 ECHO-DK11-T4 heavily impacting computer's performance #980

Open
wiktormowinski opened this issue Aug 7, 2024 · 17 comments
Assignees

Comments

@wiktormowinski
Copy link

Component

other

Device

NovaCustom V54 14th Gen

Dasharo version

v0.9.0

Dasharo Tools Suite version

Test case ID

Brief summary

There is a problem to reproduce client's evironment to get the same result as them

How reproducible

not sure

How to reproduce

that's the issue- we don't know

Expected behavior

The platform's performance is eavily impacted by dock

Actual behavior

Everything works smoothly.

Screenshots

No response

Additional context

The client complained about the performance of their computer while using Echo 11 Thunderbolt 4 ECHO-DK11-T4.
However, while running stress tests to reproduce such behaviour, the machines CPU clock and power remained relatively the same regardless if the dock was plugged or not. Therefore further investigation of this issue needed.

Solutions you've tried

current approach aimed at measuring CPU's performance, perhaps the problem lies somewhere else entirely

@zirblazer
Copy link

zirblazer commented Aug 7, 2024

I recall some guy on chat that also had performance issues when plugging a TB4 dock (Not the same one, but maybe they share a reference design/chips). IGP performance in a graphics benchmark halved by just having the dock plugged in.

@PerAstraAdDeum
Copy link

I recall some guy on chat that also had performance issues when plugging a TB4 dock (Not the same one, but maybe they share a reference design/chips). IGP performance in a graphics benchmark halved by just having the dock plugged in.

It was I who reported this issue on Matrix. Here's what I know so far:

On my own TB4 docking station (Icy Box IB-DK8801-TB4 Thunderbolt™ 4 Dock with PD 100 W), having the notebook connected and powered results in a performance drop of roughly 50% compared to the barrel-jack power connector.
The Icy Box IB-DK8801-TB4 is a rebrand of the Goodway DBD1330 Thunderbolt™ 4 / USB4 Dock Pro, which itself is based on Goshen Ridge Thunderbolt Controller afaik.

I believe the issue in question is related to power delivery. When having both the dock as well as the barrel-jack power plug connected, the notebooks performance is as expected.

@wiktormowinski
Copy link
Author

wiktormowinski commented Sep 10, 2024

Results of mentioned tests are included here:
https://pad.3mdeb.com/sheet/#/2/sheet/view/3qtlwsbhPvu3fo1ZgaTfwMUC2ia0eWj2nY21+lKTky8/

@zirblazer
Copy link

Results of mentioned tests are included here: https://pad.3mdeb.com/sheet/#/2/sheet/view/3qtlwsbhPvu3fo1ZgaTfwMUC2ia0eWj2nY21+lKTky8/

Note that you are including CPU results only. The benchmarks that were catastrophic (50% difference) were GPU related. You most likely want @PerAstraAdDeum to post his results here and what was his test environment.

@wiktormowinski
Copy link
Author

valid point, here are gpu logs:
gpu-dock-stress-test.log
gpu-stress-test.log

@zirblazer
Copy link

Well, those do seem within error margin. So I suppose we need more info from the affected users setups.

@wiktormowinski
Copy link
Author

yeah :c

@PerAstraAdDeum
Copy link

Results of mentioned tests are included here: https://pad.3mdeb.com/sheet/#/2/sheet/view/3qtlwsbhPvu3fo1ZgaTfwMUC2ia0eWj2nY21+lKTky8/

Note that you are including CPU results only. The benchmarks that were catastrophic (50% difference) were GPU related. You most likely want @PerAstraAdDeum to post his results here and what was his test environment.

Sure thing, here I am. I've done cross-testing with various drivers and kernel versions, these were my findings:

Screenshot_20240910_142839

Benchmarks were done with Unigine Superposition. I've experienced similar performance impacts with various games, always around 50% slower with docking station than without.

@PerAstraAdDeum
Copy link

After two more months I did another benchmark. Here's the result (last line):

Screenshot_20241109_131156

As you can see, the error is persistent. There's also a performance regress for the iGPU of about ten percent, that also occurs when powered by the barrel jack (4820 -> 4423, that's -8,24%). Don't know the cause of that yet.

On the bright side, it seems like only the iGPU is affected. Benchmarks with my eGPU are consistent between barrel-jack-powered and TB4-powered.

@PerAstraAdDeum
Copy link

Screenshot_20241125_132955

Today I've tried the xe driver once more, with the release of 6.12 Kernel it is rumored to be a lot more stable and reliable. So I've switched the drivers and ran some benchmarks, and, to my utter bewilderment, the performance gap between TB4 charging and barrel charging is gone!

I have absolutely no idea how this has happened, given the fact that this issue has been confirmed to be firmware-related in the Matrix chat room and there hasn't been any new firmware release since then. Anyway, everyone affected by this issue should give the xe driver a try and see if this solves the issue!

@PerAstraAdDeum
Copy link

Well, seems like we're back to where we started:

image

Now this is a benchmark done just a few minutes ago.

Coincidentally, I've been helping a dev testing some new patches for Mangohud, and I marveled at the performance of the Intel Arc iGPU:

image

When I start the game now, my framerate is considerably lower:

image

As you can see by the time shown in the HUD, there's only about 90 minutes between these runs. So whatever did impact the performance must have happened in these 90 minutes.
And indeed, something happened: the TB4 connection was interrupted, and I had to re-plug the cable.
I'm pretty sure now that this is what did halve the performance. Sadly, it prevailed a reboot. I'll try a cold boot next and see if the issue prevails.

@PerAstraAdDeum
Copy link

A cold boot didn't solve the issue.

I was however able to trick the notebook like this:

  1. Plug both TB4 as well as barrel-jack charger into the notebook.
  2. Run benchmark/graphics-demanding application.
  3. Pull barrel-jack charger.

Surprisingly I'm now back to "full-power-mode", if you will:

image

This is obviously just a hack and no viable solution.

@miczyg1
Copy link
Contributor

miczyg1 commented Dec 3, 2024

@mkopec isn't that because EC just cuts the power by cropping PL4 to the max USB-PD power? When barrel jack is plugged, then PL4 is higher and allows to reach >4000 score. Just a hunch

@PerAstraAdDeum
Copy link

@mkopec isn't that because EC just cuts the power by cropping PL4 to the max USB-PD power? When barrel jack is plugged, then PL4 is higher and allows to reach >4000 score. Just a hunch

Is there any way of testing this?

@mkopec
Copy link
Member

mkopec commented Jan 14, 2025

@mkopec isn't that because EC just cuts the power by cropping PL4 to the max USB-PD power? When barrel jack is plugged, then PL4 is higher and allows to reach >4000 score. Just a hunch

That's what I thought too.

Is there any way of testing this?

Check Limit reasons in ThrottleStop (on Windows).

The dock itself can deliver 90W which is as good as the barrel jack charger. Question is, does it actually deliver that much? That can depend on the USB-C cable. A cable may be rated for 60W, 100W or 240W, so if the cable was changed at some point, that could be the culprit. @PerAstraAdDeum Can you check the maximum power draw in throttlestop while on dock alone and while on barrel jack charger?

If it's not the cable, then I suspect the EC is having trouble determining the USB-PD power limit

@PerAstraAdDeum
Copy link

Hey, thanks for the swift reply!

Sadly I'm not running Windows. Is there a way to read those values in Linux? (Arch to be precise)

Also, about the cable. A few months ago I've changed the dock's TB4 cable for this one here: Cable Matters [Intel Certified] 40Gbps Braided Active Thunderbolt 4 Cable 2 m with 100W Charging Power.

The issue is the same with both cables though.

@PerAstraAdDeum
Copy link

@mkopec , I gave this some more thought and I'm sure it's neither the cable nor the docking station that is at fault here. As previously stated both are very well able to deliver 90 Watts (see the benchmark results). This is only possible if the notebook has been "tricked"; e.g. by plugging in the barrel jack charger, running a benchmark and pulling the barrel jack charger again.

I believe the EC having trouble determining the USB-PD power limit is the most likely culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants