Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early DMA check in ubuntu fails #985

Open
philipandag opened this issue Aug 8, 2024 · 10 comments · Fixed by Dasharo/coreboot#553
Open

Early DMA check in ubuntu fails #985

philipandag opened this issue Aug 8, 2024 · 10 comments · Fixed by Dasharo/coreboot#553
Assignees
Labels
bug Something isn't working firmware needs review novacustom_v54_mtl NovaCustom V54 Series

Comments

@philipandag
Copy link

Component

Dasharo firmware

Device

NovaCustom V54 14th Gen

Dasharo version

v0.9.1-rc1

Dasharo Tools Suite version

No response

Test case ID

EDP001.001

Brief summary

Early DMA protection check using cbmem fail

How reproducible

100% in two retries

How to reproduce

Do the EDP001.001 test manually

  • enable early DMA protection
  • boot to ubuntu
  • run sudo ./cbmem -1

Expected behavior

output should contain:
[DEBUG] VT-d @ 0xfed91000, version 5.0
[INFO ] Setting DMA protection [0x0 - 0x46c00000]
[INFO ] Setting DMA protection [0x100000000 - 0x00000008afc00000]
[INFO ] Successfully enabled VT-d PMR DMA protection

Actual behavior

root@3mdeb:/home/ubuntu# ./cbmem -1 | grep -i "dma"
?ACPI:    * DMAR
?soc_fill_dmar - gfxvtbar:0xfc800000  0xfc800001
root@3mdeb:/home/ubuntu# 
root@3mdeb:/home/ubuntu# ./cbmem -1 | grep -i "protection"
?BM-LOCKDOWN: Skipping enabling boot media protection
?ME: SPI Protection Mode Enabled : NO
root@3mdeb:/home/ubuntu# 

Screenshots

No response

Additional context

No response

Solutions you've tried

No response

@mkopec
Copy link
Member

mkopec commented Aug 9, 2024

The code to configure DMA protection is not wired up on soc/intel/meteorlake

@mkopec
Copy link
Member

mkopec commented Aug 23, 2024

Most likely just need to apply https://review.coreboot.org/c/coreboot/+/68450 but for meteorlake and that should be enough

@philipandag
Copy link
Author

I am applying the patch here: Dasharo/coreboot#553. We need the Intel FSP to compile and test it on the target platform though.

@philipandag
Copy link
Author

After applying the patch cbmem -l shows

[ERROR]  VT-d PMR HOB not found, not enabling DMA protection

@philipandag
Copy link
Author

The test passes on V560TNE with v0.9.1-rc4.

@philipandag
Copy link
Author

Not working on V540TND with v0.9.1-rc5

ubuntu@3mdeb:~$ grep -i "vt-d" cbmem-dma-enabled.log
[DEBUG]  VT-d @ 0xfc801000, version 7.0
[ERROR]  VT-d PMR HOB not found, not enabling DMA protection

cbmem-dma-enabled.log
cbmem-dma-disabled.log

@SebastianCzapla
Copy link
Contributor

Issue still present in v0.9.1-rc6.
cbmem-dma-enabled.txt

@SebastianCzapla
Copy link
Contributor

SebastianCzapla commented Oct 17, 2024

Issue still present in v0.9.1-rc7.
cbmem-dma-enabled.txt

@mkopec
Copy link
Member

mkopec commented Oct 17, 2024

@SebastianCzapla The option was supposed to be hidden, how are you testing if it's not visible?

@SebastianCzapla
Copy link
Contributor

You are right, it is not visible in the security options. I misread other option for it, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firmware needs review novacustom_v54_mtl NovaCustom V54 Series
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants