New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting unsupported variable results in unexpected error message #14

Closed

macpijan opened this issue Aug 5, 2024 · 1 comment

Contributor

macpijan commented Aug 5, 2024

We are getting: https://github.com/Dasharo/dcu/blob/b07b30340d135a2fa6548d9851abf5e2ff2473e2/test/approvals/_dcuc_variable_data_work_novacustom_nv4x_adl_v1_6_0_rom_set_SerialRedirectionInvalid_value_Enabled

We should be getting as we have before: https://github.com/Dasharo/dcu/blob/647a5147e5b2914cc92111367c725f888dd37a77/test/approvals/_dcu_variable_data_work_novacustom_nv4x_adl_v1_6_0_rom_set_SerialRedirectionInvalid_value_Enabled - or another user-friendly error message.

This is a regression caused by not running existing tests when adding new commits.

macpijan mentioned this issue

Dcuc testing #13

Merged

Contributor

philipandag commented Oct 21, 2024

Fixed in #13

https://github.com/dasharo/dcu/compare/7e4982c..4117f5c5f8bcbe8fcb43a76fceb10011b21f785a#diff-44c9f51dbfa74236bedb7af51469f2bdaf78a369b5c18842b507bcae5f5920b2L1-R1

philipandag closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment