-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(error tracking): add core agent and error tracking standalone settings #1553
feat(error tracking): add core agent and error tracking standalone settings #1553
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (74.07%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 49.28% 49.31% +0.03%
==========================================
Files 219 219
Lines 21289 21316 +27
==========================================
+ Hits 10492 10512 +20
- Misses 10250 10256 +6
- Partials 547 548 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
…add-env-vars-to-operator
62ef741
to
82cd4d9
Compare
|
||
// CoreAgent contains the settings for the core agent. | ||
// +optional | ||
CoreAgent *CoreAgent `json:"coreAgent,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config doesn't really enabled/disable core agent. The value is just added as an env var to bunch of components.
What is this configuration for? How would customer determine whether to set it to true or false?
// +k8s:openapi-gen=true | ||
type ErrorTrackingStandalone struct { | ||
// Enables Error Tracking for backend services. | ||
// Default: disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Default: disabled | |
// Default: false |
…ttings (#1553) * Add core agent and error tracking standalone settings * Simplify bool condition * set up defaults * add tests * add example * fix tests * rework into ErrorTracking.Mode * rework into single errorTrackingStandalone variable * fix typo * update generated files * doc fixes --------- Co-authored-by: Eloy Toro <[email protected]> Co-authored-by: levan-m <[email protected]> Co-authored-by: Levan Machablishvili <[email protected]>
…ttings (#1553) (#1724) * Add core agent and error tracking standalone settings * Simplify bool condition * set up defaults * add tests * add example * fix tests * rework into ErrorTracking.Mode * rework into single errorTrackingStandalone variable * fix typo * update generated files * doc fixes --------- Co-authored-by: Gianluca Bortoli <[email protected]> Co-authored-by: Eloy Toro <[email protected]> Co-authored-by: levan-m <[email protected]> Co-authored-by: Levan Machablishvili <[email protected]>
NOTE: @eloytoro has taken over the development of this feature
What does this PR do?
original PR description
It introduces the `errorTrackingStandalone` feature under APM as well as the `coreAgent` flagIt introduces the
errorTrackingStandalone
feature under APM which has theenabled
property which adds theDD_APM_ERROR_TRACKING_STANDALONE
env variable to the trace agentMotivation
We wish to inject the DD_APM_ERROR_TRACKING_STANDALONE_ENABLED env variable into the trace agent when they're provided in the config so customers can enable them and use error tracking mode of the agent which only reports spans with errors and not every span
Additional Notes
I've added an example on how to use the new flag
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
I tested this locally and I can confirm that the env var is added when the config is supplied (check the example config in this PR)
I've also added unit tests
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label