-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(error tracking): add core agent and error tracking standalone settings #1553
Merged
eloytoro
merged 17 commits into
main
from
gianluca/ERRORT-4860-add-env-vars-to-operator
Feb 24, 2025
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
301a6a8
Add core agent and error tracking standalone settings
GianlucaBortoli ccd2f66
Simplify bool condition
GianlucaBortoli 53ebb01
set up defaults
eloytoro 82e210a
add tests
eloytoro de6c6bc
add example
eloytoro 8f07d32
Merge remote-tracking branch 'origin/main' into gianluca/ERRORT-4860-…
eloytoro e42dacc
Merge remote-tracking branch 'origin/main' into gianluca/ERRORT-4860-…
eloytoro 82cd4d9
fix tests
eloytoro f1ef4de
Merge branch 'main' into gianluca/ERRORT-4860-add-env-vars-to-operator
levan-m b220604
rework into ErrorTracking.Mode
eloytoro 058aa97
Merge remote-tracking branch 'origin/main' into gianluca/ERRORT-4860-…
eloytoro 9a88670
rework into single errorTrackingStandalone variable
eloytoro 21b37a0
Merge remote-tracking branch 'origin/main' into gianluca/ERRORT-4860-…
eloytoro fcd68b5
fix typo
eloytoro 6b90322
update generated files
eloytoro 0469d8f
Merge branch 'main' into gianluca/ERRORT-4860-add-env-vars-to-operator
levan-m b5f1ca5
doc fixes
levan-m File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
examples/datadogagent/datadog-agent-with-error-tracking-standalone.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
apiVersion: datadoghq.com/v2alpha1 | ||
kind: DatadogAgent | ||
metadata: | ||
name: datadog | ||
spec: | ||
features: | ||
apm: | ||
enabled: true | ||
errorTrackingStandalone: | ||
enabled: true | ||
global: | ||
clusterName: local-k8s | ||
credentials: | ||
apiKey: <DATADOG_API_KEY> | ||
appKey: <DATADOG_APP_KEY> | ||
kubelet: | ||
tlsVerify: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config doesn't really enabled/disable core agent. The value is just added as an env var to bunch of components.
What is this configuration for? How would customer determine whether to set it to true or false?