Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTLP logs configuration #1703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support OTLP logs configuration #1703

wants to merge 1 commit into from

Conversation

shuheiktgw
Copy link
Collaborator

What does this PR do?

Closes #1442

Motivation

Support OTLP logs configuration

Additional Notes

N/A

Minimum Agent Versions

N/A

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@shuheiktgw shuheiktgw added the enhancement New feature or request label Feb 16, 2025
@shuheiktgw shuheiktgw requested review from a team as code owners February 16, 2025 10:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (1c16822) to head (fe91a32).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...al/controller/datadogagent/feature/otlp/feature.go 58.06% 11 Missing and 2 partials ⚠️
internal/controller/testutils/agent.go 0.00% 13 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1703   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files         219      219           
  Lines       21314    21352   +38     
=======================================
+ Hits        10515    10534   +19     
- Misses      10252    10270   +18     
- Partials      547      548    +1     
Flag Coverage Δ
unittests 49.33% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/datadogagent/defaults/datadogagent_default.go 91.49% <100.00%> (+0.04%) ⬆️
pkg/testutils/builder.go 91.75% <100.00%> (+0.07%) ⬆️
...al/controller/datadogagent/feature/otlp/feature.go 46.21% <58.06%> (+0.76%) ⬆️
internal/controller/testutils/agent.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16822...fe91a32. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent: OTLP Logs Support ?
3 participants