Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error tracking): add core agent and error tracking standalone settings (#1553) #1724

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Cherry-pick #1553

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

…ttings (#1553)

* Add core agent and error tracking standalone settings

* Simplify bool condition

* set up defaults

* add tests

* add example

* fix tests

* rework into ErrorTracking.Mode

* rework into single errorTrackingStandalone variable

* fix typo

* update generated files

* doc fixes

---------

Co-authored-by: Eloy Toro <[email protected]>
Co-authored-by: levan-m <[email protected]>
Co-authored-by: Levan Machablishvili <[email protected]>
@celenechang celenechang added enhancement New feature or request qa/skip-qa labels Feb 24, 2025
@celenechang celenechang requested review from a team as code owners February 24, 2025 16:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.31%. Comparing base (6d44fca) to head (bc45629).

Files with missing lines Patch % Lines
...adogagent/component/clusterchecksrunner/default.go 0.00% 4 Missing ⚠️
...nal/controller/datadogagent/feature/apm/feature.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.13    #1724      +/-   ##
==========================================
+ Coverage   49.28%   49.31%   +0.03%     
==========================================
  Files         219      219              
  Lines       21289    21316      +27     
==========================================
+ Hits        10492    10512      +20     
- Misses      10250    10256       +6     
- Partials      547      548       +1     
Flag Coverage Δ
unittests 49.31% <74.07%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/datadogagent/defaults/datadogagent_default.go 91.56% <100.00%> (+0.10%) ⬆️
pkg/testutils/builder.go 91.75% <100.00%> (+0.07%) ⬆️
...nal/controller/datadogagent/feature/apm/feature.go 65.89% <75.00%> (+0.37%) ⬆️
...adogagent/component/clusterchecksrunner/default.go 9.41% <0.00%> (-0.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d44fca...bc45629. Read the comment docs.

@celenechang celenechang merged commit c8bd725 into v1.13 Feb 24, 2025
20 checks passed
@celenechang celenechang deleted the celene/cherry-pick-1553 branch February 24, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants