Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fips image compiled with Go boringcrypto (#1731) #1737

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Feb 26, 2025

Motivation

cherr-pick #1731

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

* checkpoint: builds both with cli arg

* fips image for main build

* add jobs for generating fips image and publishing main-fips tag

* fix main fips job references

* fix param naming
@levan-m levan-m added this to the v1.13.0 milestone Feb 26, 2025
@levan-m levan-m requested a review from a team as a code owner February 26, 2025 16:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.35%. Comparing base (0716a4a) to head (fd2a865).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            v1.13    #1737   +/-   ##
=======================================
  Coverage   49.35%   49.35%           
=======================================
  Files         219      219           
  Lines       21346    21346           
=======================================
  Hits        10535    10535           
  Misses      10261    10261           
  Partials      550      550           
Flag Coverage Δ
unittests 49.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0716a4a...fd2a865. Read the comment docs.

@levan-m levan-m merged commit 946f7f4 into v1.13 Feb 26, 2025
22 checks passed
@levan-m levan-m deleted the levan-m/cherry-pick-1731 branch February 26, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants