Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Do not wrap middleware with shimmer when middleware: false in express plugin #5161

Open
billoneil opened this issue Jan 28, 2025 · 0 comments

Comments

@billoneil
Copy link

Package Name

No response

Package Version(s)

No response

Describe the feature you'd like

tracer.use("express", {
    middleware: false,
});

It appears that even when middleware tracing is disabled all of the middleware is still wrapped in shimmer.js functions. When we have very high volumes of requests GC increases significantly and the DD profiler shows a lot of time spent in shimmer.js functions including copyProperties and wrapMethod. Is it possible to not even wrap the middleware with shimmer.js when middleware tracing is disabled instead of just skipping the tracing steps?

Image

Is your feature request related to a problem?

High CPU/GC

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant